docs: fix training-job metrics shape across fine-tuning guides - #3
Open
kfastino wants to merge 1 commit into
Open
docs: fix training-job metrics shape across fine-tuning guides#3kfastino wants to merge 1 commit into
metrics shape across fine-tuning guides#3kfastino wants to merge 1 commit into
Conversation
The fine-tune-{ner,classification,extraction} and agent-skills guides
described the training-job response `metrics` field as containing
`{f1, precision, recall}`. End-to-end testing against api.pioneer.ai
confirmed that:
1. The training-job response actually returns training-loss metrics:
`{final_training_loss, final_validation_loss, best_validation_loss}`
(sourced from `brain/services/training/metrics.py`).
2. F1 / precision / recall live on the evaluation response
(`GET /felix/evaluations/:id`) with `_score` suffixes:
`{f1_score, precision_score, recall_score, accuracy}`.
3. After an evaluation runs, those numbers are merged back into the
training-job `metrics` field as `eval_f1_score`, `eval_precision`,
`eval_recall`, etc.
Updates the example JSON, the surrounding narrative ("the response
includes training loss metrics"), and the evaluation-results sentence
to match the actual API contract.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
End-to-end live testing against
api.pioneer.ai(synthetic dataset gen → 32-second LoRA training run onfastino/gliner2-base-v1→ inference + evaluation) uncovered that themetricsshape documented across the fine-tuning guides doesn't match what the API actually returns.The guides all claimed
metrics: {f1, precision, recall}on the training-job response. The real contract (perbrain/services/training/metrics.py):final_training_loss,final_validation_loss,best_validation_lossGET /felix/training-jobs/{id}→metricsf1_score,precision_score,recall_score,accuracyGET /felix/evaluations/{id}eval_f1_score,eval_precision,eval_recall,eval_accuracyGET /felix/training-jobs/{id}→metrics(merged in)Files updated
guides/fine-tune-ner.mdxguides/fine-tune-classification.mdxguides/fine-tune-extraction.mdxguides/agent-skills.mdxVerification
Verified live against
api.pioneer.ai:Test plan
brain/services/training/metrics.pyMade with Cursor