Skip to content

Conversation

kpfleming
Copy link
Contributor

Writing and then reading an item in the KV Store can sometimes fail, as the newly-written content has to replace the existing content in the cache and that does not happen instantaneously.

This PR adds logic to loop for up to 3 seconds in the KV Store tests to ensure that the newly-written content can be read.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Are there any considerations that need to be addressed for release?

as the newly-written content has to replace the existing content in
the cache and that does not happen instantaneously.

This PR adds logic to loop for up to 3 seconds in the KV Store tests
to ensure that the newly-written content can be read.
@kpfleming kpfleming added the Skip-Changelog Do not check for changelog diff label Mar 5, 2025
@kpfleming
Copy link
Contributor Author

kpfleming commented Mar 6, 2025

This is blocked until we can upgrade to the latest version of go-vcr, and we can't do that until after #626 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Skip-Changelog Do not check for changelog diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant