Skip to content

Conversation

bowrocker
Copy link
Contributor

Change summary

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

This change maintains the status quo in the case where customers make no changes to their HTTPS endpoint configuration and only leverages the new functionality if the customer explicitly opts into it. The risk of impact is low because customers using the HTTPS logging endpoint will be unaffected by this change by default.

Risk: Low

@bowrocker bowrocker requested a review from a team as a code owner September 5, 2025 17:59
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @bowrocker! 🙌

I noticed a couple of issues we’ll need to address before moving this forward:

  • I don’t see period documented in the official Fastly HTTPS logging API reference: https://www.fastly.com/documentation/reference/api/logging/https/. Since this is an open source repository, we can only support fields that are officially documented.
  • The period field also doesn’t appear to be part of the API response body.

Additionally, fixtures should not be updated manually. Instead:

  1. Remove all fixtures for the resource you’ve modified.
  2. Set your API token with FASTLY_API_KEY="your_token".
  3. Run make test to regenerate the fixtures.

Before we can merge your changes, the new field needs to be officially documented and included in the API response. Once that’s confirmed, we’ll be in a good position to proceed.

Let me know if you have any questions or if you’d like help with the fixture regeneration process. Thanks again!

@philippschulte
Copy link
Member

@bowrocker please notify me as soon as the docs changes are live. At this point we're just waiting on the docs changes. Thank you!

@bowrocker
Copy link
Contributor Author

@philippschulte the api-documentation API for this has been merged: https://github.com/fastly/api-documentation/pull/1192

We are looking to merge this as soon as possible, so please let me know what else you need.

Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @philippschulte any thoughts before merging?

@philippschulte philippschulte merged commit 25a9147 into main Sep 17, 2025
10 checks passed
@philippschulte philippschulte deleted the bulleit/https_flush_param branch September 17, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants