-
Notifications
You must be signed in to change notification settings - Fork 446
oneAPI backend update: report #1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Vivado/Vitis backends are also integrated with the build command, so that it can return a dictionary of results. Do we want to also add such functionality? |
Yes, all backends do this, so we should keep consistent. Should just be a line |
I added the change as suggested in the previous comments. Please let me know if further work is needed on this. |
Is this generally complete and ready for review? |
This needs documentation so that we know how to use it. |
Yes, this is generally complete, unless of course you have idea on how to improve it. As for the documentation, would something simple like the one for the Quartus report work? |
What is the user interface? How is the user supposed to print the report? |
The user interface is the same as for the Vivado backend. With |
The only interface we have ever "documented" is |
Description
Added functionalities for parsing and printing the QoR report when using oneAPI backend.
Type of change
This PR introduces the possibility of parsing and printing the oneAPI report, akin to what it is already possible to do using Vivado backend. All the necessary functions are contained in the
hls4ml/report/oneapi_report.py
file.Tests
Modified
test/pytest/test_report.py
to test parsing and printing of the report:test_report
directory so that Vivado and oneAPI files are included in separated subdirectoriesTest Configuration:
Checklist
pre-commit
on the files I edited or added.