Skip to content

Control where TB writes output (stdout, file, or both) #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Mar 28, 2025

Description

Testbench currently writes to file and to stdout. stdout may have limits in some environments (like the CI), obscuring important output. This PR makes it configurable via TBOutputStream of the WriterConfig section of the config.

Type of change

  • New feature (non-breaking change which adds functionality)

Tests

Added test test_tb_output_stream to test_writer_config.py but skipped for now because it requires HLS tooling.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar vloncar added the please test Trigger testing by creating local PR branch label Mar 28, 2025
@JanFSchulte JanFSchulte merged commit 3c188a8 into fastmachinelearning:main Apr 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants