Use ruff for formatting #1275
Draft
Use ruff for formatting #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmitrevs
reviewed
Apr 16, 2025
| '--skip-string-normalization'] | ||
| - id: ruff | ||
| args: [--fix] | ||
| - id: ruff-format |
There was a problem hiding this comment.
We still need to enforce the line length of 125
There was a problem hiding this comment.
It's in pyproject.toml now
jmitrevs
reviewed
Apr 16, 2025
| '--extend-ignore=E203,T201'] # E203 is not PEP8 compliant | ||
| '--extend-ignore=E203,T201,F401'] | ||
| # E203 is not PEP8 compliant | ||
| # F401 included in ruff (behaves slightly differently for noqa flags) |
There was a problem hiding this comment.
Is F401 ignored everywhere? If so, I think it's a bad idea.
There was a problem hiding this comment.
F401 included in ruff, see pyproject.toml. Only ignored for __init__.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While the current codebase favors single quote strings, black cannot enforce that (only otherwise around). This PR replaces black by ruff which can enforce single quote for one-line strings, and double quote for docstring/other multiline string.
Other formatting behavior also changes, mainly assert no longer breaks at the strange location, multiple imports from the same location will be merged automatically, etc.
This PR will introduce major merge conflicts if added as-is.
isort's functionality is covered thus removed. flake8 doesn't seem to be really necessary but is kept just in case.
Type of change