Skip to content

chore: simplify and scope CI checks#5155

Merged
ComputelessComputer merged 2 commits into
mainfrom
chore/simplify-web-ci
May 3, 2026
Merged

chore: simplify and scope CI checks#5155
ComputelessComputer merged 2 commits into
mainfrom
chore/simplify-web-ci

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented May 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Simplify web CI to shared UI build and web typecheck.
  • Remove unused Netlify preview wait and no-op web test plumbing.
  • Scope web, desktop, lint, format, database, and workflow-security CI triggers to relevant changed paths.

Note

Medium Risk
CI behavior changes (path filters and removed web E2E/preview plumbing) can lead to missed checks or reduced coverage if the trigger paths are incomplete.

Overview
Tightens CI workflow triggers by adding paths filters across database, desktop, lint, fmt, and zizmor workflows so they run only when relevant files (or the workflow itself) change.

Simplifies web_ci to only build the shared UI package and run web typechecking, removing the Netlify preview wait composite action and associated preview/test setup.

Reviewed by Cursor Bugbot for commit b403bfc. Bugbot is set up for automated code reviews on this repo. Configure here.

Keep the web CI gate to shared UI build and web typecheck while removing unused preview/test plumbing.
Constrain web, desktop, lint, format, db, and workflow security checks to the paths that can affect each job.
@netlify

netlify Bot commented May 3, 2026

Copy link
Copy Markdown

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit b403bfc
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69f704bd5e67a70009054dbb

@ComputelessComputer ComputelessComputer marked this pull request as ready for review May 3, 2026 08:22
@ComputelessComputer ComputelessComputer merged commit 335c35c into main May 3, 2026
8 of 9 checks passed
@ComputelessComputer ComputelessComputer deleted the chore/simplify-web-ci branch May 3, 2026 08:22

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b403bfc. Configure here.

- "!**/*-lock.json"
- "!**/*-lock.yaml"
- dprint.json
- .oxfmtrc.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format CI paths filter missing Python and Dockerfile patterns

Low Severity

The new paths filter in fmt.yaml doesn't include **/*.py or **/Dockerfile*, but dprint.json configures both the ruff plugin (for Python) and the dockerfile plugin. The repo contains several .py files (e.g. in scripts/) and Dockerfile files (e.g. in apps/api/, apps/stripe/). A PR that exclusively modifies these file types won't trigger the format CI at all, allowing formatting violations to be merged.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b403bfc. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant