Fix STT model display mismatch#5786
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
dfbb272 to
ad70844
Compare
Keep unavailable saved STT models visible so settings do not appear to select a different local model.
ad70844 to
8d665c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
Low Risk
Localized settings display/selection helper change with unit tests; no auth or data-path changes.
Overview
Fixes a display mismatch in AI transcription settings where the saved local/cloud model could differ from what the model dropdown showed (often the first downloaded model) even though the stored preference was unchanged.
The settings UI now derives
displayedSttModelviagetPreferredProviderModelwithkeepUnavailableSavedModel: true, so a saved model that is still known to the provider but not currently selectable (e.g. not downloaded) stays visible in the selector instead of being replaced silently.getPreferredProviderModelgains that option path; behavior without the flag is unchanged (still falls back to the first selectable model or clears).Locale
messages.pofiles were refreshed so Lingui source references track the small line shifts instt/select.tsx.Reviewed by Cursor Bugbot for commit 8d665c1. Bugbot is set up for automated code reviews on this repo. Configure here.