settings refactoring#5866
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
c73ec05 to
80ab525
Compare
80ab525 to
062372b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 062372b. Configure here.
062372b to
b358032
Compare
Routes legacy data settings to the app section and updates the settings menu metadata.
b358032 to
5d048bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Users with saved
datasettings deep links may land on a different subsection unless fallback routing is applied everywhere; moving storage UI affects where users change content paths and migrations.Overview
Reorganizes desktop settings into sidebar sections General (App with cog icon, Account, Notifications, macOS Permissions), Context (Calendar, Contacts, Templates as shortcuts to those areas), and AI (Transcription, Intelligence, Personalization).
Removes the standalone Data settings area: storage and related controls now live on the App page via
StorageSettingsView, and the Data nav label/string is dropped from catalogs. Settings tab types no longer include adataroute; normalization keeps supported subsection ids only.The Hyprnote import entry is removed from settings per the PR scope. Lingui
.po/ compiledmessages.tsfiles are updated across locales (new Context string, retargeted#:references, removal of obsolete Data entries).Reviewed by Cursor Bugbot for commit 5d048bd. Bugbot is set up for automated code reviews on this repo. Configure here.