-
Notifications
You must be signed in to change notification settings - Fork 2
Initial commit with article about skunk and github actions #99
Initial commit with article about skunk and github actions #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etagwerker really interesting! I just added a few comments
--- | ||
|
||
In preparation for my talk at [RubyConf Australia](https://www.rubyconf.org.au/) this | ||
month, I've been working on a way to make it easy for anyone to run `skunk` on their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etagwerker A link for skunk
when you mention it for first time would be nice. Maybe https://www.fastruby.io/blog/code-quality/intruducing-skunk-stink-score-calculator.html
application, you can change the last step to `skunk app/` | ||
|
||
The next thing I wanted to do is run `skunk` on a pull request in order to | ||
compare the _Stink Score_ between the pull request and `master`. This will help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etagwerker You can link Stink Score to https://github.com/fastruby/skunk#what-is-the-stinkscore
That's because I didn't change any Ruby code (just a YAML file). | ||
|
||
You can see the GitHub Action run over here: | ||
[https://github.com/fastruby/skunk/runs/437118684](https://github.com/fastruby/skunk/runs/437118684) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etagwerker fyi, it shows a syntax error there
running simple_cov
...............
sh: 1: Syntax error: "(" unexpected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lubc Yes, I noticed that, but I don't think it is a big issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been reported here: whitesmith/rubycritic#346
layout: post | ||
title: "How to Calculate Tech Debt Using Skunk on GitHub Actions" | ||
date: 2020-02-10 16:16:00 | ||
categories: ["tech-debt"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etagwerker let's add code-quality
too. Your other articles about Skunk are under that category
@lubc Just addressed your comments. 👍 |
Hey @lubc,
This is my new article about skunk and GitHub actions.
Please check it out.
Thanks!