Skip to content
This repository was archived by the owner on Dec 18, 2020. It is now read-only.

Initial commit with article about skunk and github actions #99

Merged
merged 3 commits into from
Feb 12, 2020

Conversation

etagwerker
Copy link
Member

Hey @lubc,

This is my new article about skunk and GitHub actions.

Please check it out.

Thanks!

@etagwerker etagwerker requested a review from lubc February 10, 2020 21:19
Copy link
Contributor

@lubc lubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etagwerker really interesting! I just added a few comments

---

In preparation for my talk at [RubyConf Australia](https://www.rubyconf.org.au/) this
month, I've been working on a way to make it easy for anyone to run `skunk` on their
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etagwerker A link for skunk when you mention it for first time would be nice. Maybe https://www.fastruby.io/blog/code-quality/intruducing-skunk-stink-score-calculator.html

application, you can change the last step to `skunk app/`

The next thing I wanted to do is run `skunk` on a pull request in order to
compare the _Stink Score_ between the pull request and `master`. This will help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because I didn't change any Ruby code (just a YAML file).

You can see the GitHub Action run over here:
[https://github.com/fastruby/skunk/runs/437118684](https://github.com/fastruby/skunk/runs/437118684)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etagwerker fyi, it shows a syntax error there

running simple_cov
...............
sh: 1: Syntax error: "(" unexpected

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lubc Yes, I noticed that, but I don't think it is a big issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been reported here: whitesmith/rubycritic#346

layout: post
title: "How to Calculate Tech Debt Using Skunk on GitHub Actions"
date: 2020-02-10 16:16:00
categories: ["tech-debt"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etagwerker let's add code-quality too. Your other articles about Skunk are under that category

@etagwerker
Copy link
Member Author

@lubc Just addressed your comments. 👍

@lubc lubc merged commit 3e88908 into master Feb 12, 2020
@lubc lubc deleted the post/calculate-tech-debt-with-skunk-and-gh-actions branch February 12, 2020 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants