Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model picker combines the current provider's saved models with discovery results. Switching provider, endpoint, credentials or profile keeps the previous request's models available while the replacement request loads. A response arriving after the picker closes can also restore results into an idle discovery state.
Clear models, free-model metadata and the cache flag for each new request, and cancel response handling in the effect cleanup. Keep the existing debounce and allow discovery to restart normally when reopened.
Eight hook regressions cover request identity changes, disabled discovery, late responses, closing/reopening the same provider and unmounting. The initial provider-switch and disabled-response cases both fail before the fix.
Validation: 2,316 tests across 222 files, type checks, uncached ESLint, production build and lat checks passed. Tests exercise the real hook with controlled discovery IPC; packaged desktop/live-provider validation remains pending.