Support new ARD Audiothek URL format with URN identifiers#11
Open
wieland-s wants to merge 1 commit intofbngrmr:mainfrom
Open
Support new ARD Audiothek URL format with URN identifiers#11wieland-s wants to merge 1 commit intofbngrmr:mainfrom
wieland-s wants to merge 1 commit intofbngrmr:mainfrom
Conversation
|
I applied the patch locally and tested it, it works with some programs/collections, which is great! But it could not download some single epidoses I tried to download. |
Author
Did you have an example? |
|
I've just tried it again, and as it turns out, it was an episode that cannot be downloaded at all. So not an actuall issue here. It would be nice to get a corresponding message on the command line, but in principle you have to check beforehand whether the episode is available for download at all, I guess. Tested your patch with some more programs, and they all worked fine 👍 |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes support for new ARD Audiothek URL format that uses URN identifiers instead of numeric IDs.
Changes
extractQueryId()to support both old and new URL formatsExamples:
https://www.ardaudiothek.de/sendung/pumuckl-der-hoerspiel-klassiker/72249258/https://www.ardaudiothek.de/sendung/felix-salten-bambi-komplette-lesung/urn:ard:show:566ea535038a4c82/! Not very well tested !
Closes #10