Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of improvements #43

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Lots of improvements #43

wants to merge 25 commits into from

Conversation

ceremcem
Copy link

@ceremcem ceremcem commented Jan 7, 2021

  • Added tests
  • Added "stalled branch" detection
  • Added "only submodules" filter
  • Speedup
  • Covered "Repo has no commits yet" state

Cerem Cem ASLAN and others added 19 commits May 23, 2020 01:23
fixes fboender#34
e80b73b
added tests
f2bf2df
added submodule handling
0682482
added "--only-submodules" option
dc87768
trivial speedup
e79ab99
major speedup
c486e6d
adds info output
eab9050
added example tool
f18ea2c
improves the output order
f2fd677
improved info output
17c35ed
improved argument parsing
54cf08b 
Options can now be fed before or after target directory arguments.
Any unrecognized arguments are reported instead of being silently
ignored. Argument parsing block is now more compact.
added "stalled branch detection", backward compatibility by --info
2a81012
@ceremcem
Merge pull request #1 from ceremcem/check-on-submodules
0fd212d 
Check on submodules
covered "Repo has no commits yet" states
0c83c2c
covered "Repo has no commits yet" states
81dd899
Merge branch 'check-on-submodules'
f5bf0f4
fixed tests
f20e4db
added more tests
6b92c8c
added "stalled" definition to the mgitstatus.1.md
5ee59d6
@ceremcem ceremcem mentioned this pull request Jan 7, 2021
Closed
@solarchemist
Copy link

Support for git submodules would be awesome! Great work, hope it can be incorporated into mgitstatus.

@braydentraas
Copy link

braydentraas commented Mar 15, 2021 •
edited
Loading

Git submodules is a must-have! Thanks for adding this support.

However, I have 2 issues:

  1. It doesn't work on ZSH: git config --file=.gitmodules --get-regexp ^^submodule.*\.path$ | cut -d " " -f 2 (can be fixed by wrapping the regex in quotes: "^^submodule.*\.path$")
  2. It doesn't work on macOS: find -L "$DIR" $FIND_OPTS -depth -name ".git" -printf "%h\0" (no -printf flag on BSD's find)

It worked great on Bash/Linux; I'm hoping this can be resolved and merged soon.

Cheers!

@ceremcem
Copy link
Author

@braydentraas Does gfind solve the issue on Mac: https://superuser.com/a/293200/187576?

@braydentraas
Copy link

@ceremcem Yes it does, but now readarray isn't available on mac/BSD either (or zsh even on linux)

@ceremcem
Copy link
Author

As I don't have Mac on hand, I'm not sure how to proceed here. Are you able to implement the necessary changes and test on Mac? (I even didn't know this repo has been supporting Mac)

@btraas
Copy link

btraas commented Mar 16, 2021

@ceremcem I've made a few changes and submitted a PR to your repo. Works for me now on MacOS/ZSH and Linux/Bash

Thanks again!

@OlivierJaquemet OlivierJaquemet mentioned this pull request Apr 27, 2021
Open
@aminya aminya mentioned this pull request May 14, 2022
Open
@andrejpan
Copy link

Any idea why this is not yet merged?

@ceremcem
Copy link
Author

ceremcem commented Apr 8, 2024

Don't know.

@andrejpan
Copy link

@ceremcem thank you for your updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ceremcem @solarchemist @braydentraas @btraas @andrejpan