replace SKK_DEFAULT_PATH with SKK_PATH #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wengxt
requested changes
Dec 9, 2025
CMakeLists.txt
Outdated
|
|
||
| set(SKK_DEFAULT_PATH "/usr/share/skk/SKK-JISYO.L" CACHE STRING "Default path of SKK") | ||
| set(SKK_DEFAULT_PATH "/usr/share/skk/" CACHE STRING "Default path of SKK directory that has SKK-JISYO.L, could start with \$XDG_DATA_DIRS/") | ||
| if(NOT "${SKK_DEFAULT_PATH}" MATCHES "/$") |
Member
There was a problem hiding this comment.
just make the check to be endswith SKK-JISYO.L, actually I suggest you create new string, e.g. SKK_PATH
if user override SKK_DEFAULT_PATH, then give them an error and indicate them use new variable name instead.
eagleoflqj
changed the title
eagleoflqj
force-pushed
the
default-path
branch
from
82927a2 to
02303b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify the behavior with fcitx/fcitx5-kkc@8da42fb
The benefit is more dictionaries could be added at build time.
This is a breaking change for downstream packagers that explicit set
SKK_DEFAULT_PATH.