chore: add missing jest-environment-jsdom #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdaciuk
requested changes
Jul 7, 2023
There was a problem hiding this comment.
Hey @glauberbrack, sorry for the delay! Thanks a lot for your contribution! ❤️
| "vite-tsconfig-paths": "3.5.1" | ||
| }, | ||
| "devDependencies": { | ||
| "jest-environment-jsdom": "^29.5.0" |
There was a problem hiding this comment.
Can you put this in dependencies instead of devDependencies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to clone this repository and run 'yarn test,' an error occurs due to a missing jest dependency.
Fixes # (issue)
Install the library jest-environment-jsdom in most updated version 29.5.0 as dev depency
Type of change
How Has This Been Tested?
To install dependencies in this branch, please run 'yarn'. Once dependencies are installed, you can run 'yarn test'. This should result in a successful test run.
Checklist: