Rename frontend to app, embed build outputs, and update CI/Taskfile#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
webtoappacross build tooling and CI so local layout and CI targets match the repo structure..gitkeepplaceholder and avoid accidental deletion).Description
webreferences withappin.github/workflows/ci.yml, renaming job outputs/filters and updating Node cache paths and steps to runnpm ci,npm run typecheck,npm test, andnpm run buildagainstapp.web:*tasks toapp:*(install/build/typecheck/test/dev) and updatedbuildtask dependency to useapp:build.app/scripts/clean-web-dist.mjsand updatedapp/package.jsonbuildscript to run the cleaner beforevue-tsc+vitebuild.build.outDirto../internal/web/dist,emptyOutDir: false, and added rollup manual chunking formonacoinapp/vite.config.ts.internal/web/dist/.gitkeepand updated.gitignoreto keep the placeholder while ignoring other dist files.id="root"toid="app", maderenderIndextolerant to missingdistby allowingfs.ErrNotExistto be treated as non-fatal, and updatedNewHandlerdocs and initialization to use the embedded app bundle.internal/webtests to assert onid="app"and refined the asset budget test skip logic and existence checks.Testing
task buildandtask app:buildwhich invoked the Node build and Go build workflows and completed successfully.go test ./...including updatedinternal/webtests and they passed.npm run typecheckandnpm testinappand they completed successfully.Codex Task