Type Numerical Action #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fdw please look at my PR |
fdw
requested changes
Jan 16, 2025
src/picker/argument_parsing.py
Outdated
| dest="keybinding_type_numerical", | ||
| action="store", | ||
| type=str, | ||
| default="Alt+n", |
There was a problem hiding this comment.
Do you think this is used often enough to warrant a default keybinding?
There was a problem hiding this comment.
yeah i think so. i just followed the pattern of the other actions
Naively try to remove formatting tags for selectors that don't support it. Issue: fdw#209
Instead of `poetry`, it's now `uv` and `hatchling`, because... faster and more modern. And `ruff` can replace both `black` and `isort`
� Conflicts: � uv.lock
|
@fdw sorry for the delay; life got in the way, bu now i am ready to move forward on this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
type-numericalaction to rofimoji that uses the typer to typeCtrl+Shift+U+<unicode>to enter an emoji by its unicode codepoint directly.I still need help implementing the typer functions. I don't have the compositor for wtype, so I just guessed how it works and din't test it properly