Skip to content

Refactor buttons building #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephanEggermont wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor buttons building #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab47d49
Refactor buttons building
StephanEggermont Jul 29, 2025
396228c
Use blocks instead of perform GtExampleGroup.extension.st
StephanEggermont Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 17 additions & 24 deletions src/GToolkit-Inspector/GtExampleGroup.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,24 @@ Extension { #name : #GtExampleGroup }

{ #category : #'*GToolkit-Inspector' }
GtExampleGroup >> buildButtonsContainer: aButtonsContainer listWidget: anElement [
| buttonDescriptions |
aButtonsContainer removeChildren.
aButtonsContainer addChild: (BrButton new
aptitude: BrGlamorousButtonWithLabelAptitude; beSmallSize;
label: self numberOfExamples asString, ' examples ';
action: [ anElement children second items: (self examples sorted: GtMethodsSortFunction new) ]).
aButtonsContainer addChild: (BrButton new
aptitude: BrGlamorousButtonWithLabelAptitude; beSmallSize;
label: self numberOfResults asString, ' executed ';
action: [ anElement children second items: (self executedExamples sorted: GtMethodsSortFunction new) ]).
aButtonsContainer addChild: (BrButton new
aptitude: BrGlamorousButtonWithLabelAptitude; beSmallSize;
label: self numberOfSuccesses asString, ' successes ';
action: [ anElement children second items: (self successfulExamples sorted: GtMethodsSortFunction new) ]).
aButtonsContainer addChild: (BrButton new
aptitude: BrGlamorousButtonWithLabelAptitude; beSmallSize;
label: self numberOfFailures asString, ' failures ';
action: [ anElement children second items: (self failedExamples sorted: GtMethodsSortFunction new) ]).
aButtonsContainer addChild: (BrButton new
aptitude: BrGlamorousButtonWithLabelAptitude; beSmallSize;
label: self numberOfErrors asString, ' errors ';
action: [ anElement children second items: (self erroredExamples sorted: GtMethodsSortFunction new) ]).
aButtonsContainer addChild: (BrButton new
aptitude: BrGlamorousButtonWithLabelAptitude; beSmallSize;
label: (self numberOfExamples - self numberOfResults) asString, ' skipped ';
action: [ anElement children second items: (self skippedExamples sorted: GtMethodsSortFunction new) ]).
buttonDescriptions := {
{[self numberOfExamples]. 'examples'. [self examples]}.
{[self numberOfResults]. 'executed'. [self executedExamples]}.
{[self numberOfSuccesses]. 'successes'. [self successfulExamples]}.
{[self numberOfFailures]. 'failures'. [self failedExamples]}.
{[self numberOfErrors]. 'errors'. [self erroredExamples]}.
{[self numberOfSkips]. 'skipped'. [self skippedExamples]}}.
buttonDescriptions do: [ :buttonDescription |
aButtonsContainer
addChild: (BrButton new
aptitude: BrGlamorousButtonWithLabelAptitude;
beSmallSize;
label: (buttonDescription first value) asString ,
' ', buttonDescription second, ' ';
action: [ anElement children second
items: ((buttonDescription third value) sorted: GtMethodsSortFunction new) ])].
]

{ #category : #'*GToolkit-Inspector' }
Expand Down