Minor dockerfile optimizations #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build-essential is overkill, it pulls in all of the tools one needs to make to build debian packages, which we are not doing. Even though this is a builder image, it still takes time to download all the extra crud. Replace build-essential with make gcc and g++, which are all that are needed.
The dev packages are only needed in the builder image. They add header files and docs and things that are not needed in the final image. Removing them and replacing them with just the runtime libraries reduces the final image size by about 25% (160M->124M) in a local build. Additionally, just for simplicity, zlib1g is already part of base ubuntu minimal, so we don't even have to list it.
Just like the in Dockerfile, people don't need all of those packages to build directly on their system.
emonty
requested review from
e-n-f,
migurski,
arredond,
dnomadb,
ChrisLoer and
ibesora
as code owners
|
Thanks for taking over maint! I had a PR with the builder image updates you already added and these bits against the mapbox repo since 2020. 😁 |
e-n-f
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro-optimizations for the Docker images. In the builder image we don't need all of build-essential, that is for package maintainers. We also don't need to install -dev packages in the final image, because we don't need headers and docs. Net result is slightly snappier build the first time, and a 25% reduction in final image size.