Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add language fallback for examples #2126

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

chdeskur
Copy link
Contributor

@chdeskur chdeskur commented Feb 5, 2025

This PR adds a language fallback for example selection. If no example matches the currently selected language, always attempt to find a curl example before returning no examples.

Fixes a bug reported by the Murf team.

@chdeskur chdeskur requested a review from abvthecity as a code owner February 5, 2025 21:35
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Feb 5, 2025 9:35pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Feb 5, 2025 9:35pm

Copy link

github-actions bot commented Feb 5, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Feb 5, 2025

PR Preview

@@ -49,8 +49,11 @@ export function useExampleSelection(
responseIndex: undefined,
};
}
console.log("language: ", language);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete console.log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid

Copy link

github-actions bot commented Feb 5, 2025

Playwright test results

passed  92 passed
flaky  7 flaky
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  1 minute, 31 seconds
commit  ecb872b

Flaky tests

chromium › forward-proxy/express.spec.ts › home page 404
chromium › smoke/existence.spec.ts › Check if https://docs.aiaplatform.com.au homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.conductorquantum.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.rightbrain.ai homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.subconscious.ai homepage exists
chromium › smoke/existence.spec.ts › Check if https://fern.ssoready.com homepage exists
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.givechariot.com

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants