Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OneOf and AnyOf now support more than just object variants #2129

Merged
merged 7 commits into from
Feb 6, 2025

Conversation

RohinBhargava
Copy link
Member

Short description of the changes made

  • Previously, oneOfs and anyOfs were constrained to only having object variants. This is wrong

What was the motivation & context behind this PR?

  • Customer fixes

How has this PR been tested?

  • Snapshot test

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Feb 5, 2025 11:45pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Feb 5, 2025 11:45pm

Copy link

github-actions bot commented Feb 5, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@RohinBhargava RohinBhargava marked this pull request as ready for review February 5, 2025 23:47
Copy link

github-actions bot commented Feb 5, 2025

PR Preview

Copy link

github-actions bot commented Feb 5, 2025

Playwright test results

failed  86 failed
passed  2 passed
flaky  1 flaky
skipped  12 skipped

Details

stats  101 tests across 9 suites
duration  5 minutes, 15 seconds
commit  7f1b871

Failed tests

chromium › forward-proxy/express.spec.ts › capture the flag
chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests
chromium › smoke/existence.spec.ts › Check if https://api.labelstud.io homepage exists
chromium › smoke/existence.spec.ts › Check if https://api.qdrant.tech homepage exists
chromium › smoke/existence.spec.ts › Check if https://dev.documentation.sayari.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://developers.awork.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://developers.gappify.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://developers.upwardli.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.aiaplatform.com.au homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.airtop.ai homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.anterior.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.argolabs.ai homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.boundaryml.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.cable.tech homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.cohere.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.conductorquantum.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.darwinbio.io homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.darwincloud.xyz homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.fileforge.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.fluidstack.io homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.getkard.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.givechariot.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.goldenbasis.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.instabase.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.kota.io homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.mavenagi.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.reka.ai homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.rightbrain.ai homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.schematichq.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.scorecard.io homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.sphinxbio.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.stack-auth.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.subconscious.ai homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.syndicate.io homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.trykeet.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://docs.withabound.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://fern.assemblyai.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://fern.ssoready.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://help.getzep.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://plantstore.dev homepage exists
chromium › smoke/existence.spec.ts › Check if https://secure.docs.propexo.com homepage exists
chromium › smoke/existence.spec.ts › Check if https://www.intern.mavenagi.com homepage exists
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for api.labelstud.io
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for api.qdrant.tech
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for dev.documentation.sayari.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for developers.awork.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for developers.gappify.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for developers.upwardli.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.aiaplatform.com.au
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.anterior.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.argolabs.ai
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.boundaryml.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.cable.tech
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.cohere.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.conductorquantum.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.darwinbio.io
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.darwincloud.xyz
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.fileforge.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.fluidstack.io
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.getkard.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.givechariot.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.goldenbasis.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.instabase.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.kota.io
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.mavenagi.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.reka.ai
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.rightbrain.ai
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.schematichq.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.scorecard.io
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.sphinxbio.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.stack-auth.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.subconscious.ai
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.syndicate.io
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.withabound.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for fern.assemblyai.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for help.getzep.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for plantstore.dev
chromium › smoke/versioned-docs.spec.ts › Check if https://humanloop.com/docs/v5/getting-started/overview is online
chromium › smoke/versioned-docs.spec.ts › Check if https://humanloop.com/docs/v5/api-reference is online
chromium › smoke/versioned-docs.spec.ts › Check if https://primer.io/docs/api/v2.2/introduction/getting-started is online
chromium › smoke/versioned-docs.spec.ts › Check if https://primer.io/docs/api/v2.1/api-reference/client-session-api/retrieve-client-side-token is online
chromium › smoke/versioned-docs.spec.ts › Check if https://docs.flagright.com/guides/overview/introduction is online
chromium › smoke/versioned-docs.spec.ts › Check if https://docs.flagright.com/framl-api/guides/overview/introduction is online
chromium › smoke/versioned-docs.spec.ts › Check if https://docs.flagright.com/framl-api/api-reference/webhooks/user/user-state-update is online
chromium › smoke/versioned-docs.spec.ts › Check if https://docs.flagright.com/management-api/api-reference/api-reference/get-rules is online

Flaky tests

chromium › forward-proxy/express.spec.ts › home page 404

Skipped tests

chromium › forward-proxy/express.spec.ts › redirect
chromium › forward-proxy/express.spec.ts › 404
chromium › forward-proxy/express.spec.ts › sitemap.xml
chromium › forward-proxy/express.spec.ts › revalidate-all/v3 all should work
chromium › forward-proxy/express.spec.ts › revalidate-all/v3 should work with trailing slash
chromium › forward-proxy/express.spec.ts › revalidate-all/v4 should work
chromium › forward-proxy/express.spec.ts › revalidate-all/v4 should work with trailing slash
chromium › forward-proxy/nextjs.spec.ts › redirect
chromium › forward-proxy/nextjs.spec.ts › 404
chromium › forward-proxy/nextjs.spec.ts › client-side navigation
chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

@fern-support fern-support had a problem deploying to Preview - app-dev.buildwithfern.com February 6, 2025 17:52 — with GitHub Actions Error
@fern-support fern-support had a problem deploying to Preview - app.buildwithfern.com February 6, 2025 17:52 — with GitHub Actions Error
@fern-support fern-support had a problem deploying to Preview - app-dev.buildwithfern.com February 6, 2025 17:55 — with GitHub Actions Error
@fern-support fern-support had a problem deploying to Preview - app.buildwithfern.com February 6, 2025 17:55 — with GitHub Actions Error
@RohinBhargava RohinBhargava enabled auto-merge (squash) February 6, 2025 18:23
@RohinBhargava RohinBhargava merged commit 53db319 into main Feb 6, 2025
15 of 16 checks passed
@RohinBhargava RohinBhargava deleted the rohin/one-of-any-of-union-fixes branch February 6, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants