Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: port over exploded form examples to v1 #2143

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Feb 7, 2025

Short description of the changes made

  • exploded form parameters need to be ported to v1

What was the motivation & context behind this PR?

  • support via the legacy OpenAPI parser + Fern Definitions

How has this PR been tested?

N/A

@dsinghvi dsinghvi marked this pull request as ready for review February 7, 2025 16:46
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Feb 7, 2025 4:46pm

Copy link

github-actions bot commented Feb 7, 2025

Copy link

github-actions bot commented Feb 7, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@dsinghvi dsinghvi merged commit 8bf1791 into main Feb 7, 2025
16 of 17 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/port-exploded-examples-to-v1 branch February 7, 2025 16:53
Copy link

github-actions bot commented Feb 7, 2025

PR Preview

Copy link

github-actions bot commented Feb 7, 2025

Playwright test results

passed  92 passed
flaky  7 flaky
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  1 minute, 48 seconds
commit  40e37a9

Flaky tests

chromium › forward-proxy/express.spec.ts › home page 404
chromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.cable.tech
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.cohere.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.mavenagi.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.schematichq.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.stack-auth.com

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants