feat(typescript): generate SDKs across worker shards - #17161
Open
teamchong wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
AI Review Summary
Adds worker-based sharding for TypeScript SDK generation. The core sharding logic, merge routine, and orchestration are reasonable, but there are a few correctness concerns: the validation error message wording doesn't match the tests, a potential unhandled rejection in the CLI entrypoint, and the merge's aggregate-variant single-source shortcut could still leave unmerged content.
- 🟡 3 warning(s)
- 🔵 3 suggestion(s)
teamchong
force-pushed
the
teamchong/typescript-sharded-generation
branch
2 times, most recently
from
July 22, 2026 02:45
73a1a90 to
50417ba
Compare
teamchong
force-pushed
the
teamchong/typescript-sharded-generation
branch
from
July 22, 2026 14:24
50417ba to
53aa06d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add internal worker sharding for TypeScript SDK generation and merge each worker's output into one SDK.
Benchmark
Cloudflare's canonical TypeScript IR, three alternating runs:
Both modes generated 22,573 files. After the workflow's formatting step, there were zero normalized content differences.
Testing