-
Notifications
You must be signed in to change notification settings - Fork 268
Update overview.mdx for CLI overview #2674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix capitalization issue fix broken link to generators page
|
Forgot to mention that I changed:
to
Reason: According to The OpenAPI Initiative, the OpenAPI Specification (OAS) is the actual specification itself, whereas documents using specification to describe APIs are called OpenAPI Descriptions (OAD). |
|
Sounds like |
|
I looked into this further. First, I looked at what other major companies use. There's a wide range of terms in use including "OpenAPI document", "OpenAPI spec", "OAS document", "OAS file", "OpenAPI file", "API defined in OAS 3", "OAS definition", "OpenAPI definition", and so on. I noticed that even the official spec at openapis.org uses the term "OpenAPI Document" instead of the "OpenAPI Description" term used in learn.openapis.org. I descended a rabbit hole that led me to a PR and a long Oct '23 discussion in the open-api Slack. That discussion ended with the OAI Technical Steering Committee agreeing on "OpenAPI Description (OAD)". Other contenders in the discussion were "OpenAPI Document" and "OpenAPI Definition", but using "OpenAPI Specification" or "OpenAPI spec" to refer to a file that conforms to the spec seems to be universally considered incorrect by the OAI. GitHub is an example of an org that uses the OAI-preferred terminology. I would recommend regarding the OAI as the source of truth and going forward with "OpenAPI Description" and "OAD", or "OpenAPI Document" (which is conveniently also OAD) as a secondary choice. |
|
Thanks for diving into this. Given this ambiguity, my instinct is to go with what's most commonly used by devs. Pick the colloquially term, not necessarily the steering-committee-defined "right" term. Github search results As a result, I think we should use Curious for your thoughts! |
|
It's hard to gauge how many of the results from the github search for That said, I agree it seems to be in more common usage, and I can see the value in a descriptive approach vs prescriptive, and using a term more people may be familiar with/might search for. I like the idea of including an explanatory blurb somewhere. Do you want to use "OpenAPI spec" or "OpenAPI Spec" across the board instead of "OpenAPI Specification"? This PR affected a line that said "An OpenAPI Specification" - did you want to use "An OpenAPI Spec" here, or perhaps "A file conforming to the OpenAPI spec"? |
|
I'm up for using |
|
I would do the same for |
For now, mostly just fixing a capitalization issue (first letter of a sentence not capitalized) and a broken link to the generators page.
Seems like this page could use further revision though. The section on generator schema seems out of place here and I would think it makes more sense on the generators page, or the fern generate page. The section on compilers could maybe go, too. The information on fern login seems germane (and could be expanded upon), and perhaps a link to the fern help page could be added along with note about ability to use --help flag for each command; also perhaps a section on logging.