unused darglint config removed from the setup.cfg (#111)

* unused darglint config removed from the setup.cfg * darglint dedicated checks removed * change remove pipfile.lock and test workflow * revert intentional error Co-authored-by: ali <[email protected]>
fetchai · Mar 21, 2022 · 2c33ce8 · 2c33ce8
1 parent 92fe965
commit 2c33ce8
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 21 deletions.
diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml
@@ -31,7 +31,6 @@ jobs:
         tox -e isort-check
         tox -e flake8
         tox -e vulture
-        tox -e darglint-check
     - name: Security check
       run: tox -e bandit
     - name: Safety check

diff --git a/.gitignore b/.gitignore
@@ -4,13 +4,13 @@
 ./build/
 dist/
 build/
+Pipfile.lock
 
 # IDEs
 .idea/
 
 # Tox files
 .tox
-Pipfile.lock
 
 .DS_Store
 */.DS_Store

diff --git a/Makefile b/Makefile
@@ -232,7 +232,7 @@ new_env_dev: clean
 	if [ -z "$v" ];\
 	then\
 		pipenv --rm;\
-		pipenv install --dev;\
+		pipenv install --dev --skip-lock --clear;\
 		echo "Enter virtual environment with all development dependencies now: 'pipenv shell'.";\
 	else\
 		echo "In a virtual environment! Exit first: 'exit'.";\

diff --git a/setup.cfg b/setup.cfg
@@ -5,7 +5,7 @@ select = B,C,D,E,F,I,W,
 exclude=.md,
     vulture_whitelist.py
     cosmpy/protos
-ignore = E501, W503
+ignore = E501, W503, DAR401
 docstring_style=sphinx
 strictness=full
 # E501: Line too long
@@ -49,13 +49,6 @@ ignore_missing_imports = True
 [mypy-certifi.*]
 ignore_missing_imports = True
 
-[darglint]
-docstring_style=sphinx
-strictness=full
-ignore_regex=.*_pb2\.py
-ignore=DAR401
-
-
 [isort]
 profile = black
 skip = protos

diff --git a/tox.ini b/tox.ini
@@ -17,16 +17,6 @@ deps =
   black==21.6b0
 commands = black --check --verbose cosmpy tests examples setup.py --exclude protos
 
-
-[testenv:darglint-check]
-allowlist_externals=bash
-skipsdist = True
-skip_install = True
-deps =
-  darglint==1.8.0
-commands = bash -c "find ./scripts/ ./tests/ ./cosmpy -iname '*.py'|grep -v cosmpy/protos|xargs darglint"
-
-
 [testenv:black]
 skipsdist = True
 skip_install = True