Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting session_id in ctx.send #232

Closed
wants to merge 1 commit into from

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Feb 20, 2024

Allow users to overwrite the session id by setting it in ctx.send(). This means that an agent can send messages for a previous session and not necessarily the one given by the incoming envelope.

This can be useful for example when information needs to be collected from other agents before responding to a request.

@jrriehl jrriehl requested review from Archento and Dacksus February 20, 2024 18:46
@Archento
Copy link
Member

Code wise this looks good but as @Dacksus already posted I also think that we should discuss before adding the session_id to messages as this would potentially allow session spoofing if implemented incorrectly.
Maybe we should go forward with the Dialogue implementation first and create a good working example from that.

@jrriehl
Copy link
Contributor Author

jrriehl commented Feb 21, 2024

Agreed, closing this.

@jrriehl jrriehl closed this Feb 21, 2024
@Archento Archento deleted the feat/send-session-id branch March 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants