Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): asgi error message due to missing body #516

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

Archento
Copy link
Member

A new bug was introduced in the last PR where you'll receive an error log message from the ASGI server due to an incomplete message.

ERROR: ASGI callable returned without completing response.

These logs would be triggered whenever a message has been sent as the callee would send an incomplete acknowledgement.

Copy link
Contributor

@Alejandro-Morales Alejandro-Morales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works fine!

@Archento Archento merged commit 3a76aa0 into main Aug 28, 2024
9 checks passed
@Archento Archento deleted the fix/asgi-error-msg branch August 28, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants