Skip to content

Conversation

@Sunz3r
Copy link

@Sunz3r Sunz3r commented Jan 14, 2016

if the node_id contains invalid characters then rrd-update interrupt the backend-script

if the node_id contains invalid characters then rrd-update interrupt the backend-script
@lost-tty
Copy link

Thanks!

Could you

  • refactor the else branch to an if branch to make it clearer what's being tested?
  • add a note to the readme stating what is considered a valid node id so people don't have to read the code?
  • write a more descriptive commit message stating what the problem is and how it was addressed? This should also include a short description of what makes a node id valid.

@rubo77
Copy link
Contributor

rubo77 commented Oct 30, 2017

@Sunz3r are you still planing to get this straight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants