forked from mkst/sm64-port
-
Notifications
You must be signed in to change notification settings - Fork 42
[PS2] HD Support, video mode selector, make iso script #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
freshollie
wants to merge
16
commits into
fgsfdsfgs:ps2
Choose a base branch
from
freshollie:ps2-hd
base: ps2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ab72fcb
fix booting from OPL, add make iso
freshollie decdfef
finished
freshollie d9c1ff3
remove
freshollie e62a282
fixes
freshollie 7600db4
fix tearing
freshollie d6ec5f4
downgrade default res
freshollie f088d3f
undo 3 pass
freshollie 021c387
fix
freshollie 35dd6d4
undo change
freshollie 9abab4f
fix 1080i issues, at dithering
freshollie 4ee642a
correct queue exec
freshollie e22594d
initial implementation of video mode selection
freshollie ec2267d
fix broken commit
freshollie 8d46c4a
save resolution preference
freshollie 2da8221
source improvements
freshollie 14051a4
fixes
freshollie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| BOOT2 = cdrom0:\SLUS_064.64;1 | ||
| VER = 1.00 | ||
| VMODE = NTSC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -316,6 +316,10 @@ static void gfx_ps2_set_viewport(int x, int y, int width, int height) { | |
| r_view.x = x; | ||
| r_view.y = y; | ||
| r_view.w = width; | ||
| // 1080i requires the view point is half height | ||
| if (gs_global->Mode == GS_MODE_DTV_1080I) { | ||
| height /= 2; | ||
| } | ||
| r_view.h = height; | ||
| r_view.hw = r_view.w * 0.5f; | ||
| r_view.hh = r_view.h * 0.5f; | ||
|
|
@@ -324,6 +328,11 @@ static void gfx_ps2_set_viewport(int x, int y, int width, int height) { | |
| } | ||
|
|
||
| static inline void draw_set_scissor(const int x0, const int y0, const int x1, const int y1) { | ||
| // scissor doesn't work with gskit hires | ||
| if (gs_global->Mode == GS_MODE_DTV_720P || gs_global->Mode == GS_MODE_DTV_1080I) { | ||
| return; | ||
| } | ||
|
|
||
| u64 *p_data = gsKit_heap_alloc(gs_global, 1, 16, GIF_AD); | ||
|
|
||
| *p_data++ = GIF_TAG_AD(1); | ||
|
|
@@ -645,7 +654,6 @@ static void draw_clear(const u64 color) { | |
|
|
||
| u32 pos = 0; | ||
|
|
||
| strips++; | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was one of the major bugs, doesn't show up on low res but hires it makes lines all over the screen. It's possibly something which was left in by mistake. |
||
| while (strips--) { | ||
| gsKit_prim_sprite(gs_global, pos, 0, pos + 64, gs_global->Height, 0, color); | ||
| pos += 64; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convinient way to create an ISO, perhaps mkiosfs needs to be added to the docker image?