chore: Metrics , tracks commands , errors for now #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinikatyal
changed the title
neha-nupoor
reviewed
May 26, 2025
vinikatyal
changed the title
vinikatyal
commented
May 28, 2025
core/analytics/tracker.py
Outdated
| from opentelemetry.metrics import set_meter_provider, get_meter_provider | ||
| from opentelemetry.sdk.metrics.export import ( | ||
| PeriodicExportingMetricReader, | ||
| ConsoleMetricExporter |
Contributor
Please add a better description and title. The title + description should clearly and succinctly convey what the PR is doing to anyone: not just the team, but any viewer on the Internet who looks through our history, |
core/analytics/client.py
Outdated
|
|
||
| def get_client_id() -> str: | ||
| """Retrieve or create a unique, anonymous client ID for this user.""" | ||
| path = os.path.join(os.path.expanduser("~"), ".compliant-llm", ".client-id") |
Contributor
There was a problem hiding this comment.
os.path.expanduser("~"): this will probably not work across platforms.
please look into Path.home()
core/analytics/tracker.py
Outdated
| logger.info("✅ Azure Monitor traces initialized.") | ||
| except Exception as e: | ||
| logger.error(f"❌ Failed to initialize tracing: {e}") | ||
| print(f"❌ Failed to initialize tracing: {e}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Results
Reference Links
Checklist
This PR includes the following (tick all that apply):