Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add node scheduling control #366

Merged
merged 7 commits into from
Jan 16, 2025
Merged

feat: add node scheduling control #366

merged 7 commits into from
Jan 16, 2025

Conversation

strahe
Copy link
Contributor

@strahe strahe commented Jan 14, 2025 •
edited
Loading

Changes

  • Add unschedulable field to harmony_machines
  • Implement cordon operation to mark node as unschedulable
  • Implement uncordon operation to resume node scheduling

https://filecoinproject.slack.com/archives/C06GD1SS56Y/p1736216228423539

@strahe strahe marked this pull request as draft January 14, 2025 06:24
@strahe strahe marked this pull request as ready for review January 14, 2025 07:00
LexLuthr
LexLuthr requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the Cordon status in UI (Node list on main page and node info page both) and also a command to check the same?

cmd/curio/cordon.go Outdated Show resolved Hide resolved
harmony/harmonytask/harmonytask.go Outdated Show resolved Hide resolved
@strahe
Copy link
Contributor Author

strahe commented Jan 14, 2025

Does this look good? Any suggestions?

image
image

@strahe strahe marked this pull request as draft January 14, 2025 10:25
@LexLuthr
Copy link
Contributor

UI looks good. Please push the changes.

@strahe strahe force-pushed the feat/maintenance-mode branch from 0a1d2ef to e83d25f Compare January 15, 2025 04:33
@strahe
Copy link
Contributor Author

strahe commented Jan 15, 2025 •
edited
Loading

We can check the cordon status using the info command,
but the translation doesn't seem to take effect for me
image

@strahe strahe marked this pull request as ready for review January 15, 2025 05:32
@strahe strahe requested a review from LexLuthr January 15, 2025 05:32
LexLuthr
LexLuthr approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Thank you!

@LexLuthr LexLuthr merged commit 401f542 into filecoin-project:main Jan 16, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr LexLuthr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strahe @LexLuthr