feat: streaming upload #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kubuxu and @hugomrdias to do intial review |
Kubuxu
reviewed
Oct 2, 2025
|
The approach seems very much reasonable to me |
Based on your review, I will proceed with rest of the code and testing. Thank you for a quick review. |
rvagg
reviewed
Oct 6, 2025
|
this is a nicer, much less hacky version of what I was imagining, so 👍 |
LexLuthr
force-pushed
the
feat/streaming-upload
branch
from
e9434a1 to
e0847b3
Compare
hugomrdias
approved these changes
Oct 6, 2025
rvagg
added a commit
to FilOzone/synapse-sdk
that referenced
this pull request
Oct 6, 2025
First pass at supporting the new flow @ filecoin-project/curio#668 Second pass at this would expose the stream up through the SDK so you're not forced to pass down byte arrays. For now, this is just internal and hides the details outside of PDPServer.
|
Draft SDK impl @ FilOzone/synapse-sdk#280 |
rvagg
added a commit
to FilOzone/synapse-sdk
that referenced
this pull request
Oct 9, 2025
First pass at supporting the new flow @ filecoin-project/curio#668 Second pass at this would expose the stream up through the SDK so you're not forced to pass down byte arrays. For now, this is just internal and hides the details outside of PDPServer.
rvagg
reviewed
Oct 9, 2025
rvagg
reviewed
Oct 9, 2025
rvagg
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
tested with FilOzone/synapse-sdk#280 and this is non-breaking so I'm happy for this to go in and we can work on upgrade strategy on the client side separately
LexLuthr
force-pushed
the
feat/streaming-upload
branch
from
f8a8249 to
0a255a8
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.