Skip to content

fix: index migration and IPNI canAccept #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: index migration and IPNI canAccept #684

wants to merge 5 commits into from

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Oct 7, 2025 •
edited
Loading

I will be dropping index migration due to high op cost for now. This PR will add some conversion to allow v1 and v2 lookup both.

@LexLuthr LexLuthr requested a review from a team as a code owner October 7, 2025 15:48
magik6k
magik6k reviewed Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CanAccept makes sense to me.

Little worried about performance in UpdatePieceCidV1ToV2, that reads like it can cause some serious problems for larger SPs with 100s of billions of index entries (i.e. pib-scale or with blockchain data)

@LexLuthr LexLuthr linked an issue Oct 8, 2025 that may be closed by this pull request
Fix indexing piece cid v1 to v2 migration #656
Closed
magik6k
magik6k reviewed Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@LexLuthr LexLuthr force-pushed the fix/mk20-indexing branch 2 times, most recently from 4b92f1e to 338060b Compare October 10, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magik6k magik6k magik6k left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix indexing piece cid v1 to v2 migration

2 participants

@LexLuthr @magik6k