Skip to content

feat: add Grafana tutorial and templates #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025
Merged

Conversation

rjan90
Copy link
Collaborator

@rjan90 rjan90 commented Oct 24, 2023

Porting over the Grafana dashboard tutorial from here: filecoin-project/lotus#11276 and updated in: filecoin-project/lotus#12934.

Can be merged once 12934 lands

@BigLep
Copy link
Member

BigLep commented Sep 24, 2024

@rjan90 : would it be helpful for me to review so this can land?

@rjan90
Copy link
Collaborator Author

rjan90 commented Sep 26, 2024

I think the progress on this PR stopped, when I mentally expanded the scope of this work by trying to write up "how to setup Graphing on a remote machine", but for now I think setting it up locally is just fine. I will look at doing a cleanup of this PR on 2024-09-30

Adding Grafana dashboard tutorial
Update weights across tutorial section
@rjan90 rjan90 force-pushed the feat/add-grafana-tutorial branch from ffbb6fb to 856ccc3 Compare November 14, 2024 03:58
@BigLep BigLep marked this pull request as draft January 6, 2025 20:16
@BigLep BigLep moved this from 🐱 Todo to 👊 Needs Commitment in FilOz Mar 17, 2025
chore: update Grafana tutorial
@rjan90 rjan90 changed the title Add Grafana tutorial feat: add Grafana tutorial and templates Apr 10, 2025
@rjan90 rjan90 marked this pull request as ready for review April 10, 2025 16:05
@rjan90 rjan90 moved this from 👊 Needs Commitment to 🔎 Awaiting Review in FilOz Apr 10, 2025
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your judgement here, but I would look at how to reduce the duplication between this and filecoin-project/lotus#12934 . Ideally we're doing more pointing from one to the other than copy/pasting

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Apr 12, 2025
rjan90 and others added 2 commits April 21, 2025 13:58
Reduce duplication between Lotus docs and the Metrics readme in the Lotus repo
@rjan90
Copy link
Collaborator Author

rjan90 commented Apr 23, 2025

I trust your judgement here, but I would look at how to reduce the duplication between this and filecoin-project/lotus#12934 . Ideally we're doing more pointing from one to the other than copy/pasting

I have reduced the duplication by pointing to the https://github.com/filecoin-project/lotus/blob/master/metrics/README.md for instructions.

@rjan90 rjan90 merged commit f21a6aa into main Apr 23, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

2 participants