Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Introduced ComPtr #16152

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Code Quality: Introduced ComPtr #16152

merged 1 commit into from
Sep 9, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Sep 8, 2024 •
edited
Loading

@yaira2 yaira2 requested review from hez2010 and hishitetsu September 8, 2024 14:26
@hishitetsu
Copy link
Member

Sorry it is out of my skill set.

@yaira2 yaira2 merged commit 0aea31f into files-community:main Sep 9, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 9, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-ComPtr2 branch September 9, 2024 03:37
@0x5bfa 0x5bfa changed the title Code Quality: Introduced ComPtr for unmanaged COM pointers Code Quality: Introduced ComPtr Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hez2010 hez2010 hez2010 approved these changes

@hishitetsu hishitetsu Awaiting requested review from hishitetsu

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Quality: Dispose unmanaged objects automatically using IDisposable
4 participants
@0x5bfa @hishitetsu @hez2010 @yaira2