Adding a compatible layout for RTL cultures

src/Files.App.CsWin32/NativeMethods.txt

@@ -156,3 +156,5 @@ IApplicationDestinations
 ApplicationDestinations
 IApplicationDocumentLists
 ApplicationDocumentLists
+SetWindowLongPtr
+GetWindowLongPtr

src/Files.App/Dialogs/AddBranchDialog.xaml.cs

@@ -21,6 +21,7 @@ public AddBranchDialogViewModel ViewModel
 		public AddBranchDialog()
 		{
 			InitializeComponent();
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		public new async Task<DialogResult> ShowAsync() => (DialogResult)await base.ShowAsync();

src/Files.App/Dialogs/AddItemDialog.xaml.cs

@@ -24,6 +24,7 @@ public AddItemDialogViewModel ViewModel
 		public AddItemDialog()
 		{
 			InitializeComponent();
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		public new async Task<DialogResult> ShowAsync()

src/Files.App/Dialogs/BulkRenameDialog.xaml.cs

@@ -19,6 +19,7 @@ public BulkRenameDialogViewModel ViewModel
 		public BulkRenameDialog()
 		{
 			InitializeComponent();
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		public new async Task<DialogResult> ShowAsync()

src/Files.App/Dialogs/CreateArchiveDialog.xaml.cs

@@ -65,6 +65,7 @@ public CreateArchiveDialog()
 			InitializeComponent();
 
 			ViewModel.PropertyChanged += ViewModel_PropertyChanged;
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		public new Task<ContentDialogResult> ShowAsync()

src/Files.App/Dialogs/CreateShortcutDialog.xaml.cs

@@ -29,6 +29,7 @@ public CreateShortcutDialog()
 			{
 				Source = ShortcutTarget
 			});
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		private void CreateShortcutDialog_Closing(ContentDialog sender, ContentDialogClosingEventArgs args)

src/Files.App/Dialogs/CredentialDialog.xaml.cs

@@ -21,6 +21,7 @@ public CredentialDialogViewModel ViewModel
 		public CredentialDialog()
 		{
 			InitializeComponent();
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		public new async Task<DialogResult> ShowAsync()

src/Files.App/Dialogs/DecompressArchiveDialog.xaml.cs

@@ -22,6 +22,7 @@ public DecompressArchiveDialogViewModel ViewModel
 		public DecompressArchiveDialog()
 		{
 			InitializeComponent();
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		private void ContentDialog_PrimaryButtonClick(ContentDialog sender, ContentDialogButtonClickEventArgs args)

src/Files.App/Dialogs/DynamicDialog.xaml.cs

@@ -34,6 +34,7 @@ public DynamicDialog(DynamicDialogViewModel dynamicDialogViewModel)
 
 			dynamicDialogViewModel.HideDialog = Hide;
 			ViewModel = dynamicDialogViewModel;
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		private void ContentDialog_PrimaryButtonClick(ContentDialog sender, ContentDialogButtonClickEventArgs args)

src/Files.App/Dialogs/ElevateConfirmDialog.xaml.cs

@@ -23,6 +23,7 @@ public ElevateConfirmDialogViewModel ViewModel
 		public ElevateConfirmDialog()
 		{
 			InitializeComponent();
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		public new async Task<DialogResult> ShowAsync()

src/Files.App/Dialogs/FileTooLargeDialog.xaml.cs

@@ -20,6 +20,7 @@ public FileTooLargeDialogViewModel ViewModel
 		public FileTooLargeDialog()
 		{
 			InitializeComponent();
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		public new async Task<DialogResult> ShowAsync()

src/Files.App/Dialogs/FilesystemOperationDialog.xaml.cs

@@ -32,6 +32,7 @@ public FilesystemOperationDialog()
 			InitializeComponent();
 
 			MainWindow.Instance.SizeChanged += Current_SizeChanged;
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		public new async Task<DialogResult> ShowAsync()

src/Files.App/Dialogs/GitHubLoginDialog.xaml.cs

@@ -29,6 +29,7 @@ public GitHubLoginDialogViewModel ViewModel
 		public GitHubLoginDialog()
 		{
 			InitializeComponent();
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		public new async Task<DialogResult> ShowAsync()

src/Files.App/Dialogs/ReleaseNotesDialog.xaml.cs

@@ -23,6 +23,7 @@ public ReleaseNotesDialog()
 			InitializeComponent();
 
 			MainWindow.Instance.SizeChanged += Current_SizeChanged;
+			AppLanguageHelper.UpdateContextLayout(this);
 			UpdateDialogLayout();
 		}
 

src/Files.App/Dialogs/ReorderSidebarItemsDialog.xaml.cs

@@ -29,6 +29,7 @@ public ReorderSidebarItemsDialogViewModel ViewModel
 		public ReorderSidebarItemsDialog()
 		{
 			InitializeComponent();
+			AppLanguageHelper.UpdateContextLayout(this);
 		}
 
 		private async void MoveItemAsync(object sender, PointerRoutedEventArgs e)

src/Files.App/Dialogs/SettingsDialog.xaml.cs

@@ -24,6 +24,7 @@ public SettingsDialog()
 			InitializeComponent();
 
 			MainWindow.Instance.SizeChanged += Current_SizeChanged;
+			AppLanguageHelper.UpdateContextLayout(this);
 			UpdateDialogLayout();
 		}
 

src/Files.App/Helpers/Application/AppLanguageHelper.cs

@@ -1,11 +1,18 @@
 // Copyright (c) 2024 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
+using Microsoft.UI.Xaml;
 using System.Globalization;
+using System.Text.RegularExpressions;
 using Windows.Globalization;
+using WinRT.Interop;
+using Windows.Win32;
+using Windows.Win32.Foundation;
+using Windows.Win32.UI.WindowsAndMessaging;
 
 namespace Files.App.Helpers
 {
+	// TODO: Replaced by RealTime Resources in the future
 	/// <summary>
 	/// Provides static helper to manage supported languages in the application.
 	/// </summary>
@@ -27,6 +34,10 @@ public static class AppLanguageHelper
 		/// </summary>
 		public static AppLanguageItem PreferredLanguage { get; private set; }
 
+		public static CultureInfo PreferredCulture => new(PreferredLanguage.Code);
+
+		public static FlowDirection FlowDirection => PreferredCulture.TextInfo.IsRightToLeft ? FlowDirection.RightToLeft : FlowDirection.LeftToRight;
+
 		/// <summary>
 		/// Initializes the <see cref="AppLanguageHelper"/> class.
 		/// </summary>
@@ -48,10 +59,10 @@ static AppLanguageHelper()
 
 			// Set the system default language as the first item in the Languages collection
 			var systemLanguage = new AppLanguageItem(CultureInfo.InstalledUICulture.Name, systemDefault: true);
-			if (appLanguages.Select(lang => lang.Name.Contains(systemLanguage.Name)).Any())
-				appLanguages[0] = systemLanguage;
-			else
-				appLanguages[0] = new("en-US", systemDefault: true);
+
+			appLanguages[0] = appLanguages.Select(lang => lang.Name.Contains(systemLanguage.Name)).Any()
+				? systemLanguage
+				: new("en-US", systemDefault: true);
 
 			// Initialize the list
 			SupportedLanguages = new(appLanguages);
@@ -104,5 +115,50 @@ public static bool TryChange(string code)
 			ApplicationLanguages.PrimaryLanguageOverride = index == 0 ? _defaultCode : PreferredLanguage.Code;
 			return true;
 		}
+
+		// TODO: Replaced by RealTime Resources in the future
+		/// <summary>
+		/// Updates the title bar layout of the specified window based on the current culture.
+		/// </summary>
+		/// <param name="window">The window to be updated.</param>
+		/// <returns>True if the update was successful; otherwise, false.</returns>
+		public static bool UpdateTitleBar(Window window)
+		{
+			try
+			{
+				var hwnd = new HWND(WindowNative.GetWindowHandle(window));
+				var exStyle = PInvoke.GetWindowLongPtr(hwnd, WINDOW_LONG_PTR_INDEX.GWL_EXSTYLE);
+
+				exStyle = PreferredCulture.TextInfo.IsRightToLeft
+					? new((uint)exStyle | (uint)WINDOW_EX_STYLE.WS_EX_LAYOUTRTL) // Set RTL layout
+					: new((uint)exStyle.ToInt64() & ~(uint)WINDOW_EX_STYLE.WS_EX_LAYOUTRTL); // Set LTR layout
+
+				if (PInvoke.SetWindowLongPtr(hwnd, WINDOW_LONG_PTR_INDEX.GWL_EXSTYLE, exStyle) == 0)
+					return false;
+			}
+			catch (Exception)
+			{
+				return false;
+			}
+
+			return true;
+		}
+
+		// TODO: Replaced by RealTime Resources in the future
+		public static void UpdateContextLayout(FrameworkElement element)
+		{
+			element.FlowDirection = FlowDirection;
+		}
+
+		// TODO: Replaced by RealTime Resources in the future
+		public static bool SetCultureLayout(Window window)
+		{
+			var res = UpdateTitleBar(window);
+			if (!res)
+				return res;
+			if (window.Content is FrameworkElement element)
+				UpdateContextLayout(element);
+			return res;
+		}
 	}
 }

src/Files.App/Helpers/Win32/Win32PInvoke.Methods.cs

@@ -1,4 +1,4 @@
-// Copyright (c) 2024 Files Community
+// Copyright (c) 2024 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
 using System.IO;

src/Files.App/MainWindow.xaml.cs

@@ -42,6 +42,8 @@ public void ShowSplashScreen()
 			var rootFrame = EnsureWindowIsInitialized();
 
 			rootFrame?.Navigate(typeof(SplashScreenPage));
+
+			AppLanguageHelper.UpdateTitleBar(Instance);
 		}
 
 		public async Task InitializeApplicationAsync(object activatedEventArgs)
@@ -196,6 +198,7 @@ public async Task InitializeApplicationAsync(object activatedEventArgs)
 
 			if (Windows.Win32.PInvoke.IsIconic(new(WindowHandle)))
 				WinUIEx.WindowExtensions.Restore(Instance); // Restore window if minimized
+			AppLanguageHelper.UpdateContextLayout(rootFrame);
 		}
 
 		private Frame? EnsureWindowIsInitialized()

src/Files.App/UserControls/AddressToolbar.xaml

@@ -263,63 +263,68 @@
 					</AnimatedIcon>
 				</ToggleButton>
 
-				<Button
-					x:Name="Back"
-					AccessKey="B"
-					AccessKeyInvoked="Button_AccessKeyInvoked"
-					AutomationProperties.FullDescription="{x:Bind ViewModel.Commands.NavigateBack.Description, Mode=OneWay}"
-					AutomationProperties.Name="{x:Bind ViewModel.Commands.NavigateBack.Label, Mode=OneWay}"
-					Command="{x:Bind ViewModel.Commands.NavigateBack, Mode=OneWay}"
-					IsEnabled="{x:Bind ViewModel.Commands.NavigateBack.IsExecutable, Mode=OneWay}"
-					Style="{StaticResource AddressToolbarButtonStyle}"
-					ToolTipService.ToolTip="{x:Bind ViewModel.Commands.NavigateBack.LabelWithHotKey, Mode=OneWay}">
-					<FontIcon FontSize="14" Glyph="{x:Bind ViewModel.Commands.NavigateBack.Glyph.BaseGlyph, Mode=OneWay}" />
-					<Button.ContextFlyout>
-						<MenuFlyout
-							x:Name="BackHistoryFlyout"
-							Opening="BackHistoryFlyout_Opening"
-							Placement="BottomEdgeAlignedLeft"
-							ScrollViewer.VerticalScrollBarVisibility="Auto"
-							ScrollViewer.VerticalScrollMode="Auto">
-							<MenuFlyout.MenuFlyoutPresenterStyle>
-								<Style TargetType="MenuFlyoutPresenter">
-									<Setter Property="MaxHeight" Value="400" />
-									<!--  Workaround for https://github.com/files-community/Files/issues/13078  -->
-									<Setter Target="HighContrastAdjustment" Value="None" />
-								</Style>
-							</MenuFlyout.MenuFlyoutPresenterStyle>
-						</MenuFlyout>
-					</Button.ContextFlyout>
-				</Button>
-
-				<Button
-					x:Name="Forward"
-					AccessKey="F"
-					AccessKeyInvoked="Button_AccessKeyInvoked"
-					AutomationProperties.FullDescription="{x:Bind ViewModel.Commands.NavigateForward.Description, Mode=OneWay}"
-					AutomationProperties.Name="{x:Bind ViewModel.Commands.NavigateForward.Label, Mode=OneWay}"
-					Command="{x:Bind ViewModel.Commands.NavigateForward, Mode=OneWay}"
-					IsEnabled="{x:Bind ViewModel.Commands.NavigateForward.IsExecutable, Mode=OneWay}"
-					Style="{StaticResource AddressToolbarButtonStyle}"
-					ToolTipService.ToolTip="{x:Bind ViewModel.Commands.NavigateForward.LabelWithHotKey, Mode=OneWay}">
-					<FontIcon FontSize="14" Glyph="{x:Bind ViewModel.Commands.NavigateForward.Glyph.BaseGlyph, Mode=OneWay}" />
-					<Button.ContextFlyout>
-						<MenuFlyout
-							x:Name="ForwardHistoryFlyout"
-							Opening="ForwardHistoryFlyout_Opening"
-							Placement="BottomEdgeAlignedLeft"
-							ScrollViewer.VerticalScrollBarVisibility="Auto"
-							ScrollViewer.VerticalScrollMode="Auto">
-							<MenuFlyout.MenuFlyoutPresenterStyle>
-								<Style TargetType="MenuFlyoutPresenter">
-									<Setter Property="MaxHeight" Value="400" />
-									<!--  Workaround for https://github.com/files-community/Files/issues/13078  -->
-									<Setter Target="HighContrastAdjustment" Value="None" />
-								</Style>
-							</MenuFlyout.MenuFlyoutPresenterStyle>
-						</MenuFlyout>
-					</Button.ContextFlyout>
-				</Button>
+				<StackPanel
+					x:Name="NavigationButtons"
+					FlowDirection="{Binding Path=FlowDirection, ElementName=Root}"
+					Orientation="Horizontal">
+					<Button
+						x:Name="Back"
+						AccessKey="B"
+						AccessKeyInvoked="Button_AccessKeyInvoked"
+						AutomationProperties.FullDescription="{x:Bind ViewModel.Commands.NavigateBack.Description, Mode=OneWay}"
+						AutomationProperties.Name="{x:Bind ViewModel.Commands.NavigateBack.Label, Mode=OneWay}"
+						Command="{x:Bind ViewModel.Commands.NavigateBack, Mode=OneWay}"
+						IsEnabled="{x:Bind ViewModel.Commands.NavigateBack.IsExecutable, Mode=OneWay}"
+						Style="{StaticResource AddressToolbarButtonStyle}"
+						ToolTipService.ToolTip="{x:Bind ViewModel.Commands.NavigateBack.LabelWithHotKey, Mode=OneWay}">
+						<FontIcon FontSize="14" Glyph="{x:Bind ViewModel.Commands.NavigateBack.Glyph.BaseGlyph, Mode=OneWay}" />
+						<Button.ContextFlyout>
+							<MenuFlyout
+								x:Name="BackHistoryFlyout"
+								Opening="BackHistoryFlyout_Opening"
+								Placement="BottomEdgeAlignedLeft"
+								ScrollViewer.VerticalScrollBarVisibility="Auto"
+								ScrollViewer.VerticalScrollMode="Auto">
+								<MenuFlyout.MenuFlyoutPresenterStyle>
+									<Style TargetType="MenuFlyoutPresenter">
+										<Setter Property="MaxHeight" Value="400" />
+										<!--  Workaround for https://github.com/files-community/Files/issues/13078  -->
+										<Setter Target="HighContrastAdjustment" Value="None" />
+									</Style>
+								</MenuFlyout.MenuFlyoutPresenterStyle>
+							</MenuFlyout>
+						</Button.ContextFlyout>
+					</Button>
+
+					<Button
+						x:Name="Forward"
+						AccessKey="F"
+						AccessKeyInvoked="Button_AccessKeyInvoked"
+						AutomationProperties.FullDescription="{x:Bind ViewModel.Commands.NavigateForward.Description, Mode=OneWay}"
+						AutomationProperties.Name="{x:Bind ViewModel.Commands.NavigateForward.Label, Mode=OneWay}"
+						Command="{x:Bind ViewModel.Commands.NavigateForward, Mode=OneWay}"
+						IsEnabled="{x:Bind ViewModel.Commands.NavigateForward.IsExecutable, Mode=OneWay}"
+						Style="{StaticResource AddressToolbarButtonStyle}"
+						ToolTipService.ToolTip="{x:Bind ViewModel.Commands.NavigateForward.LabelWithHotKey, Mode=OneWay}">
+						<FontIcon FontSize="14" Glyph="{x:Bind ViewModel.Commands.NavigateForward.Glyph.BaseGlyph, Mode=OneWay}" />
+						<Button.ContextFlyout>
+							<MenuFlyout
+								x:Name="ForwardHistoryFlyout"
+								Opening="ForwardHistoryFlyout_Opening"
+								Placement="BottomEdgeAlignedLeft"
+								ScrollViewer.VerticalScrollBarVisibility="Auto"
+								ScrollViewer.VerticalScrollMode="Auto">
+								<MenuFlyout.MenuFlyoutPresenterStyle>
+									<Style TargetType="MenuFlyoutPresenter">
+										<Setter Property="MaxHeight" Value="400" />
+										<!--  Workaround for https://github.com/files-community/Files/issues/13078  -->
+										<Setter Target="HighContrastAdjustment" Value="None" />
+									</Style>
+								</MenuFlyout.MenuFlyoutPresenterStyle>
+							</MenuFlyout>
+						</Button.ContextFlyout>
+					</Button>
+				</StackPanel>
 
 				<Button
 					x:Name="Up"
@@ -691,6 +696,20 @@
 						<Setter Target="StatusInfoBadge.Style" Value="{StaticResource CriticalIconInfoBadgeStyle}" />
 					</VisualState.Setters>
 				</VisualState>
+				<!--  FlowDirection LeftToRight  -->
+				<VisualState x:Name="LTR">
+					<VisualState.Setters>
+						<Setter Target="NavigationButtons.Children[0]" Value="Back" />
+						<Setter Target="NavigationButtons.Children[1]" Value="Forward" />
+					</VisualState.Setters>
+				</VisualState>
+				<!--  FlowDirection RightToLeft  -->
+				<VisualState x:Name="RTL">
+					<VisualState.Setters>
+						<Setter Target="NavigationButtons.Children[0]" Value="Forward" />
+						<Setter Target="NavigationButtons.Children[1]" Value="Back" />
+					</VisualState.Setters>
+				</VisualState>
 			</VisualStateGroup>
 		</VisualStateManager.VisualStateGroups>
 	</Grid>