Code Quality: Removed Vanara from ShellPreviewViewModel#16945
Conversation
0x5bfa
force-pushed
the
5bfa/CQ-CsWin32ShellPreviewing
branch
from
b7f4136 to
449f1dc
Compare
|
CC @hez2010 Ready, confirmed to be working well. |
|
I'm OOF this week. Will take a look later. |
yair100
force-pushed
the
main
branch
7 times, most recently
from
30cea65 to
decf3da
Compare
hez2010
left a comment
hez2010
left a comment
There was a problem hiding this comment.
Overall LGTM. Left some comments.
| _windProc = new(WndProc); | ||
| var pWindProc = Marshal.GetFunctionPointerForDelegate(_windProc); | ||
| var pfnWndProc = (delegate* unmanaged[Stdcall]<HWND, uint, WPARAM, LPARAM, LRESULT>)pWindProc; |
There was a problem hiding this comment.
I would like to avoid using GetFunctionPointerForDelegate. Instead, marking WndProc as static and UnmanagedCallersOnly and taking a function pointer from it directly.
While we don't need to do it immediately in this PR as it may require some refactor to WndProc.
There was a problem hiding this comment.
Yeah. Since making proc-s static has huge impact like you said, i was hesitant to do this (while I understand using GetFunctionPointerForDelegate has performance impact likewise)
There was a problem hiding this comment.
Im curious, if you were to, how would you refactor (roughly)?
yair100
added
ready to merge
|
@0x5bfa can you please resolve the conflicts? |
…wModel.cs Co-authored-by: Steve <hez2010@outlook.com> Signed-off-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
0x5bfa
force-pushed
the
5bfa/CQ-CsWin32ShellPreviewing
branch
from
0ca9b55 to
141bc82
Compare
4 participants
Resolved / Related Issues
Steps used to test these changes