Skip to content

Fix: Force Close when Rearranging Pin items in side bar #17044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ChengYi0224
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

  1. Open Files
  2. In Pinned scroller, right click a testing folder.
  3. Left click "unpin from sidebar" and see if it is removed properly.

@yaira2
Copy link
Member

yaira2 commented Apr 21, 2025

@ChengYi0224 thank you for the PR. Can you clarify how this resolves #16808? This issue is regarding the feature to reorder pinned items, as far as I can tell, there isn't any connection with pinning and unpinning items.

@yaira2 yaira2 force-pushed the main branch 2 times, most recently from 75d29b5 to aa7d7fa Compare April 22, 2025 22:33
@yaira2 yaira2 closed this May 1, 2025
@ChengYi0224
Copy link
Contributor Author

Thank you for reviewing this PR. I should clarify that this change may not directly resolve issue #16808 regarding reordering pinned items.

I encountered a threading-related issue when working with pinned items, specifically with the unpinfromhome verb, which led me to submit this PR after discussion with a developer in Discord. The issue I experienced was triggered by an external application (OneDrive) interacting with explorer services.

While my PR ensures the fi.InvokeVerb("unpinfromhome") call runs within an STA context, I now realize it's not directly addressing the reordering functionality described in #16808. I apologize for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Force Close when Rearranging Pin items in side bar
2 participants