-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix ShowOnShift #4877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ShowOnShift #4877
Conversation
@yaichenbaum @cinqmilleans I believe we still want to be showing |
@winston-de That's not the behavior I envisioned, I expected the overflow to work the same was as it does with other items. |
@yaichenbaum I'm not sure if I'm fully understanding, is this the behavior you expect?
This is how it currently behaves in this pr:
I would like to note that the main reason for moving |
@winston-de No. The behavior of this pr is false. The good is writed in the description. |
@cinqmilleans Yes I realize my mistake, I apologize for that. |
@winston-de Thanks you. Now it is good. |
@winston-de the second chart is closer to the expected behavior, the only difference is that it shouldn't automatically be moved to the overflow menu when it's turned on. It should only move to the overflow menu if there are more than three items before it. |
Hiding I would suggest something more like this to help avoid confusion about when items are shown and to keep features accessible when using a touchscreen.
|
@winston-de That looks like a satisfactory solution. |
@yaichenbaum @winston-de Ok, I do it tomorrow. |
@yaichenbaum @winston-de The branch is commited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, LGTM
Resolved / Related Issues
The functionnality ShowOnShift is bugged.
The expected behavior of ShowOnShift is to show the command only if shift is pressed.
The real behavior of ShowOnShift is to show the command in More when Shift is not pressed.
This is the cause of #4850.
Details of Changes
When Shift is not held, the items with ShowOnShift are not displayed.
Else the items are displayed, in the main or more menu, depending on the settings.
Validation
How did you test these changes?