Skip to content

Fix copy/paste for shortcuts #6109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2021
Merged

Fix copy/paste for shortcuts #6109

merged 3 commits into from
Sep 12, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Sep 12, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Fixed an issue preventing copy/paste to work for shortcuts & hidden items
  • Avoid blocking UI when loading icons for the conflict dialog (dialog open faster when deleting many items)

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 requested a review from winston-de September 12, 2021 15:12
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 12, 2021
@yaira2 yaira2 merged commit 988453b into files-community:main Sep 12, 2021
@yaira2 yaira2 mentioned this pull request Sep 12, 2021
Closed
@gave92 gave92 deleted the fixes branch September 13, 2021 00:42
@yaira2 yaira2 mentioned this pull request Oct 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winston-de winston-de winston-de approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't copy or move shortcuts
3 participants
@gave92 @winston-de @yaira2