Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage object comparison operator #67

Closed
hameerabbasi opened this issue Jun 6, 2024 · 3 comments
Closed

Storage object comparison operator #67

hameerabbasi opened this issue Jun 6, 2024 · 3 comments

Comments

@hameerabbasi
Copy link
Collaborator

          But we don't really have a string representation of a format or a format property in the `Tensor` class. So there's no way checking if the current format is e.g. `csf` and I would prefer to avoid parsing Julia's `_obj` repr if it matches some regex - it appears counterproductive to me.

Originally posted by @mtsokol in #45 (comment)

@willow-ahrens
Copy link
Collaborator

We could recursively walk the levels creating copies and error if we reach a level where the formats don't match. Even if we had a string format thing, we would still need to recurse down the levels to do the copy.

@willow-ahrens
Copy link
Collaborator

Perhaps typeof should suffice

@willow-ahrens
Copy link
Collaborator

I think this is a dup of #13, and for now we can use typeof until we merge #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants