-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy
keyword for asarray
, Tensor
, and astype
#45
Conversation
56a2edb
to
967020f
Compare
copy
keyword for asarray
, Tensor
, and astype
copy
keyword for asarray
, Tensor
, and astype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Julia not have a way to do a deep copy?
Hmm let's discuss it during Finch meeting. But I would leave copying logic in Python and not rely on Julia copying, considering that we already have no-copy logic for NumPy and SciPy inputs in |
Would you like to implement it later, or in this PR? If the former, let's raise an issue to keep track. |
Let's implement it in a follow-up PR. You mean to allow copying Julia input, right? Like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP copy keyword for
asarray
,Tensor
, andastype
.Fixes #46