fix julia package versioning, bump finch/juliapkg #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsokol
approved these changes
Mar 2, 2025
mtsokol
reviewed
Mar 4, 2025
| import juliacall as jc # noqa | ||
|
|
||
| juliapkg.resolve() |
There was a problem hiding this comment.
@willow-ahrens For the pydata/sparse notebook job that is failing with missing dependencies, maybe we should we have juliapkg.resolve() here? https://github.com/pydata/sparse/actions/runs/13648682369
There was a problem hiding this comment.
Yes. It's strange that tests pass here but fail there. It may be that resolve is only called on the first instance of loading juliacall, so if pydatasparse imports juliacall and then imports finch later, resolve doesn't get called with the new deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the docs for pyjuliapkg a little better. Note the discussion in JuliaPy/pyjuliapkg#45 about why the old behavior was not thread safe. I believe this should work better. I think this should fix pydata/sparse#767 because of the aforementioned fix to pyjuliapkg. This would remove support for envvars that dictate the version of Finch to use, in favor of modifying the juliapkg.json file. I don't think this is that much more or less convenient than the old solution, but it is correct with how the maintainer of pyjuliapkg expected the system to be used.