[feat] Portfolio Page 구현 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altmit
added
chore
altmit
commented
Nov 29, 2024
Comment on lines
+39
to
+40
| //TODO 왜 styled로 감싼 컴포넌트에 component props가 안되는지 | ||
| // component="div" |
Member
Author
There was a problem hiding this comment.
다음 이슈에서 Pagination 관련으로 styled 문제도 함께 찾아보기
Comment on lines
+28
to
+31
| //TODO : toast 추가 | ||
| // const message = (error as AxiosError<Response<null>>).response?.data | ||
| // ?.message as string; | ||
| // toast.error(message); |
Comment on lines
+11
to
+16
| // type Props = { | ||
| // tab: PortfolioPageTab; | ||
| // onChangeTab: (tab: PortfolioPageTab) => void; | ||
| // }; | ||
|
|
||
| // export default function ChartsPanel({ tab, onChangeTab }: Props) { |
Comment on lines
+21
to
+35
| // const { | ||
| // data: portfolioSSE, | ||
| // //TODO: SSE 에러일때 핸들링처리 | ||
| // } = useSSE<PortfolioSSE>({ | ||
| // url: `/api/portfolio/${portfolioId}/holdings/realtime`, | ||
| // eventTypeName: "portfolioDetails", | ||
| // }); | ||
|
|
||
| // // Static Data | ||
| // const { portfolioDetails, portfolioHoldings } = portfolio; | ||
| // // Realtime Data | ||
| // const { | ||
| // portfolioDetails: portfolioDetailsSSE, | ||
| // portfolioHoldings: portfolioHoldingsSSE, | ||
| // } = portfolioSSE ?? { portfolioDetails: null, portfolioHoldings: [] }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현한 것
기타 변경 사항
Maximum update depth exceeded에러 발생