FDC3 For Web Browsers Implementation #1309
Open
+69,877
−42,945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriswest
force-pushed
the
fdc3-for-web
branch
from
bd27747 to
e2a8a55
Compare
11 tasks
This comment was marked as outdated.
This comment was marked as outdated.
julianna-ciq
requested changes
Nov 4, 2024
| Then "{result}" is an error with message "TargetAppUnavailable" | ||
|
|
||
| Scenario: void is returned in the result | ||
| Given Raise Intent will return no result |
There was a problem hiding this comment.
Suggested change
| Given Raise Intent will return no result | |
| Given Raise Intent returns no result |
| | OrderFood | fdc3.instrument | AAPL | chipShop | c1 | raiseIntentRequest | | ||
|
|
||
| Scenario: Context Data is returned in the result | ||
| Given Raise Intent will return a context of "{instrumentContext}" |
There was a problem hiding this comment.
Suggested change
| Given Raise Intent will return a context of "{instrumentContext}" | |
| Given Raise Intent returns a context of "{instrumentContext}" |
| | OrderFood | fdc3.instrument | AAPL | raiseIntentRequest | | ||
|
|
||
| Scenario: App Channel is returned in the result | ||
| Given Raise Intent will return an app channel |
There was a problem hiding this comment.
Suggested change
| Given Raise Intent will return an app channel | |
| Given Raise Intent returns an app channel |
| | OrderFood | fdc3.instrument | AAPL | raiseIntentRequest | | ||
|
|
||
| Scenario: User Channel is returned in the result | ||
| Given Raise Intent will return a user channel |
There was a problem hiding this comment.
Suggested change
| Given Raise Intent will return a user channel | |
| Given Raise Intent returns a user channel |
| | OrderFood | fdc3.instrument | AAPL | raiseIntentRequest | | ||
|
|
||
| Scenario: Private Channel is returned in the result | ||
| Given Raise Intent will return a private channel |
There was a problem hiding this comment.
Suggested change
| Given Raise Intent will return a private channel | |
| Given Raise Intent returns a private channel |
julianna-ciq
reviewed
Nov 4, 2024
packages/fdc3-get-agent/test/step-definitions/desktop-agent.steps.ts
Outdated
Show resolved
Hide resolved
packages/fdc3-get-agent/test/step-definitions/desktop-agent.steps.ts
Outdated
Show resolved
Hide resolved
packages/fdc3-get-agent/test/step-definitions/desktop-agent.steps.ts
Outdated
Show resolved
Hide resolved
kriswest
requested changes
Nov 4, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
julianna-ciq
reviewed
Nov 7, 2024
| And "App1/a1" is opened with connection id "a1" | ||
| And "listenerApp/b1" is opened with connection id "b1" | ||
| And "listenerApp/b1" registers an intent listener for "returnBook" | ||
| # Scenario: Context Not Handled By App |
There was a problem hiding this comment.
These lines should be deleted.
Comment on lines
119
to
123
| # Scenario: Raising An Invalid Intent (non existent intent but valid app) | ||
| # When "App1/a1" raises an intent for "nonExistentIntent" with contextType "fdc3.book" on app "listenerApp/b1" | ||
| # Then messaging will have outgoing posts | ||
| # | msg.payload.error | msg.type | | ||
| # | NoAppsFound | raiseIntentResponse | |
There was a problem hiding this comment.
Suggested change
| # Scenario: Raising An Invalid Intent (non existent intent but valid app) | |
| # When "App1/a1" raises an intent for "nonExistentIntent" with contextType "fdc3.book" on app "listenerApp/b1" | |
| # Then messaging will have outgoing posts | |
| # | msg.payload.error | msg.type | | |
| # | NoAppsFound | raiseIntentResponse | |
There was a problem hiding this comment.
Do we need this? What does this file accomplish for the repo?
robmoffat
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
At least it's helping me persuade myself to buy a bigger laptop (rendering the diff takes some doing) ;-) It's also a huge contribution of work to the standard which will have a massive positive impact on it if you/we pull it off. Looking forward to helping get that done. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
|
3 similar comments
|
|
|
|
|
|
|
Preview here: https://deploy-preview-1309--fdc3.netlify.app |
This comment was marked as outdated.
This comment was marked as outdated.
Fdc3 for web impl fixes rm
Allow DAs to customize timeoutsand apps to control logging
This comment was marked as outdated.
This comment was marked as outdated.
|
|
kriswest
previously approved these changes
Jan 29, 2025
|
|
kriswest
approved these changes
Jan 29, 2025
julianna-ciq
approved these changes
Jan 29, 2025
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation PR for FDC3 for the Web (#896)
This PR primarily implements the
getAgent()function (in the fdc3-get-agent package) as defined by the FDC3 Web Connection Protocol (WCP) and aDesktopAgentProxy(in the fdc3-agent-proxy package) that it uses to implement communication with browser-based Desktop Agents via the FDC3 Desktop Agent Communication Protocol (DACP).Additionally, the FDC3 repository is refactored to be a monorepo supported by
npm workspaces. The existing repository was split into fdc3-context (context type definitions), fdc3-schems (bridging and DACP protocol messages) and fdc3-standard (existing API TypeScript definitions, Intents and App Directory) packages. A testing package was added with tooling used in multiple packages for testing.These packages are rolled up for release on NPM by an fdc3 package (publishing to the existing @finos/fdc3 NPM package). Previous releases provided both ES6 and CommonJs modules within a single package - this release will only provide ES6, with a separate fdc3-commonjs module provided for backwards compatibility (will release at @finos/fdc3-commonjs).
Finally, a reference implementation, demo for FDC3 in a Web Browser and reference channel selector and intent resolver UIs (that can be injected into an app by getAgent) are provided in the toolbox/fdc3-for-web package.