-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JEAN BAPTISTE ZIADE CorporateActionEnrichment_FRAGMOS #3220
base: master
Are you sure you want to change the base?
Conversation
Enrichmenent of CorporateAction event
✅ Deploy Preview for finos-cdm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Background :
Target : |
CorporateAction_Enrichment_FRAGMOS_update
improve description of corporate actions
Hi @JBZ-Fragmos , Adding my comments as discussed during today's DPBE and also part of the reviews we talked back in December. We observe the contribution extends the CorporateAction model. We think these additions improve flexibility but we have identified areas requiring further clarification and action to maintain compatibility and compliance. The removal of the underlier attribute from the On the removal of the To finalize this contribution, please resolve any existing conflicts and share the release notes. Thanks. |
Hi @manuel ***@***.***>
Thanks for your feedback
To clarify the proposal, with the hope this will answer your questions, I have not removed the Enum value "transfer" I have just renamed it to "novation" - please see below, when comparing prior version to new version after changes, you can see that description for "novation" dully correspond to prior name of the value as "transfer"
Honestly that is not a critical point, so if really a blocker then I can move it back to "transfer", but in my view, the best name for designating "a transfer of the position to another clearing member" is "novation" - hence proposal for renaming
Let me know if find as it is given my explanation, or if you still have an issue on this point
Kind regards
JB
From: Manel Martos ***@***.***>
Sent: Wednesday, January 15, 2025 7:14 PM
To: finos/common-domain-model ***@***.***>
Cc: Jean-Baptiste Ziadé ***@***.***>; Mention ***@***.***>
Subject: Re: [finos/common-domain-model] JEAN BAPTISTE ZIADE CorporateActionEnrichment_FRAGMOS (PR #3220)
Hi @JBZ-Fragmos<https://github.com/JBZ-Fragmos> ,
Adding my comments as discussed during today's DPBE and also part of the reviews we talked back in December.
We observe the contribution extends the CorporateAction model. We think these additions improve flexibility but we have identified areas requiring further clarification and action to maintain compatibility and compliance.
The removal of the underlier attribute from the CorporateAction type does not affect event qualification logic or the downstream DRR processes. This adjustment has been discussed and accepted at the relevant Working Groups.
On the removal of the PositionEventIntentEnum -> Transfer, the DRR model as a consumer needs a clear justification or an alternative solution (e.g. Substitution). This value plays a role in reporting early termination events at the position level. It is essential to clarify how such scenarios should now be addressed and ensure that the model remains compliant with these regulatory jurisdictions.
To finalize this contribution, please resolve any existing conflicts and share the release notes<https://cdm.finos.org/docs/contribution#release-note>.
Thanks.
-
Reply to this email directly, view it on GitHub<#3220 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFL2POKH2QEXEHCF6CYA3D2K2QPTAVCNFSM6AAAAABRIQQ5H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJTGYZTMNZVGU>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
same with screenshot
Hi @manuel ***@***.***>
Thanks for your feedback
To clarify the proposal, with the hope this will answer your questions, I have not removed the Enum value "transfer" I have just renamed it to "novation" - please see below, when comparing prior version to new version after changes, you can see that description for "novation" dully correspond to prior name of the value as "transfer"
***@***.***
Honestly that is not a critical point, so if really a blocker then I can move it back to "transfer", but in my view, the best name for designating "a transfer of the position to another clearing member" is "novation" - hence proposal for renaming
Let me know if find as it is given my explanation, or if you still have an issue on this point
Kind regards
JB
From: Manel Martos ***@***.******@***.***>>
Sent: Wednesday, January 15, 2025 7:14 PM
To: finos/common-domain-model ***@***.******@***.***>>
Cc: Jean-Baptiste Ziadé ***@***.******@***.***>>; Mention ***@***.******@***.***>>
Subject: Re: [finos/common-domain-model] JEAN BAPTISTE ZIADE CorporateActionEnrichment_FRAGMOS (PR #3220)
Hi @JBZ-Fragmos<https://github.com/JBZ-Fragmos> ,
Adding my comments as discussed during today's DPBE and also part of the reviews we talked back in December.
We observe the contribution extends the CorporateAction model. We think these additions improve flexibility but we have identified areas requiring further clarification and action to maintain compatibility and compliance.
The removal of the underlier attribute from the CorporateAction type does not affect event qualification logic or the downstream DRR processes. This adjustment has been discussed and accepted at the relevant Working Groups.
On the removal of the PositionEventIntentEnum -> Transfer, the DRR model as a consumer needs a clear justification or an alternative solution (e.g. Substitution). This value plays a role in reporting early termination events at the position level. It is essential to clarify how such scenarios should now be addressed and ensure that the model remains compliant with these regulatory jurisdictions.
To finalize this contribution, please resolve any existing conflicts and share the release notes<https://cdm.finos.org/docs/contribution#release-note>.
Thanks.
-
Reply to this email directly, view it on GitHub<#3220 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFL2POKH2QEXEHCF6CYA3D2K2QPTAVCNFSM6AAAAABRIQQ5H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJTGYZTMNZVGU>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
@JBZ-Fragmos - we'll ask to a DRR positions SMEs to clarify this change specifically since it'll require a consumer upgrade and come back. |
[like] Jean-Baptiste Ziadé reacted to your message:
…________________________________
From: Manel Martos ***@***.***>
Sent: Thursday, January 16, 2025 12:06:23 PM
To: finos/common-domain-model ***@***.***>
Cc: Jean-Baptiste Ziadé ***@***.***>; Mention ***@***.***>
Subject: Re: [finos/common-domain-model] JEAN BAPTISTE ZIADE CorporateActionEnrichment_FRAGMOS (PR #3220)
I have just renamed it to "novation"
@JBZ-Fragmos<https://github.com/JBZ-Fragmos> - we'll ask to a DRR positions SMEs to clarify this change specifically since it'll require a consumer upgrade and come back.
—
Reply to this email directly, view it on GitHub<#3220 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFL2PNG7IMC4VMODOZHIQD2K6OD7AVCNFSM6AAAAABRIQQ5H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJVGM2TINBSGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@JBZ-Fragmos, the DRR consumer member has also accepted the term "Novation" instead of "Transfer" so it shouldn't prevent the contribution once ready under CDM latest version. Thanks! |
@manel-martos thanks to you, for the review and the feedback |
No description provided.