Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent namespace convention #458

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

dschwartznyc
Copy link
Contributor

To support serialization testing, updated the Rune name space and JSON @type to facilitate consistent testing

  • New feature (non-breaking change which adds functionality)

Copy link

linux-foundation-easycla bot commented Feb 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@@ -1,4 +1,4 @@
namespace cardinality
namespace serialization.test.roundtripfail.cardinality
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The round trip tests all take an input, deserialise it into a Rune object, then serialise it out and assert that the before input matches the resulting output. The error handling tests will assert an error when you attempt to serialise back out on that last step. Could we rename all these error namespaces to remove the roundtrip to avoid confusion. How about serialization.test.error...

Copy link
Contributor Author

@dschwartznyc dschwartznyc Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not plussed about the specific naming as long as there are no clashes and there's a clear delineation between the collection of tests that are expected to pass and the collection that are expected to fail. We use that distinction to automatically differentiate the tests according to their expected outcomes (assert pass vs assert fail).

For example:

passing tests: serialization.test.pass...
failing tests: serialization.test.fail...

@davidalk davidalk mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants