Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

250: adding a temporary change in reminderController #459

Open
wants to merge 1 commit into
base: spring-bot-master
Choose a base branch
from

Conversation

kapirath28
Copy link

its my first contribution just tried to fix the issue by

-In the addreminder method, before adding a new reminder, ichecked if the Reminder has a valid time in the future.

-removed reminders from the list that have a localTime before the current time (LocalDateTime.now())

(i am a beginner at this let me know about it.)

Copy link

linux-foundation-easycla bot commented Jan 24, 2025

CLA Not Signed

@kapirath28
Copy link
Author

its my first contribution just tried to fix the issue 250

@kapirath28 kapirath28 closed this Jan 24, 2025
@robmoffat
Copy link
Member

#250

Hi @kapirath28,

Thanks for this - why did you close it? I think you were on the right track. Just looking at the Reminder Bot with @vaibhav-db , we think the "check it's in the future" code should be in this class:

https://github.com/finos/spring-bot/blob/spring-bot-master/tools/reminder-bot/src/main/java/org/finos/springbot/tool/reminders/TimeFinder.java

Do you want to have another try?

@robmoffat robmoffat reopened this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants