BD-4612 resolve epoch seconds formatting errors#332
Draft
edrotthoff wants to merge 13 commits intodevelopfrom
Draft
BD-4612 resolve epoch seconds formatting errors#332edrotthoff wants to merge 13 commits intodevelopfrom
edrotthoff wants to merge 13 commits intodevelopfrom
Conversation
added 12 commits
April 15, 2024 10:44
testing only action
add action
prototype new epoch time conversion
call the prototype
reference access
bug fix for first three months of year
mod 12 not 11
make months 0 based
bug on prefix 0
clairify the month value logistics.
remove test only code for epoch time formatting
merge Develop into project branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modify the epoch seconds formatting logic to work properly.
tests were made to perform detailed QA on the formatting, these require special setup in the contracts, and so are used to unit test this this code for dev, and QA purposes. the new test is named BD-4612-epoch-formatting-tests.js.