Skip to content

feat: Many train category expander improvements & SP migration#510

Merged
MoritzWeber0 merged 15 commits into
mainfrom
feat/migrate-sp
Dec 21, 2025
Merged

feat: Many train category expander improvements & SP migration#510
MoritzWeber0 merged 15 commits into
mainfrom
feat/migrate-sp

Conversation

@MoritzWeber0
Copy link
Copy Markdown
Member

@MoritzWeber0 MoritzWeber0 commented Dec 16, 2025

  • Update archetypes to reflect the train category changes
  • Avoid showing the Reservation heading within expanders in toc
  • Add ship as train category type
  • Add new "Scheduled routes" section within train category expanders
  • Add id attribute for HTML anchors to create links to operators directly (expander is opened if referenced via link)
  • Migrate SP & SBB

@github-actions
Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 16, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 1594750
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/694805465d40560008c3268f
😎 Deploy Preview https://deploy-preview-510--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lenderom
Copy link
Copy Markdown
Member

Thank your for your migration efforts ❤️

What do you think about having informations about the reservations as an own section seperated from the text at the end?
Like you have it done at SNCF?
This way users can clearly see information about the reservation. I wouldn't do this a 100% strict rule but I think we should try to stick to it.

What do you think? :)
image

@MoritzWeber0 MoritzWeber0 marked this pull request as draft December 18, 2025 19:46
@MoritzWeber0 MoritzWeber0 changed the title feat: Migrate SP page to new train category expanders feat: Many train category expander improvements & SP migration Dec 18, 2025
@MoritzWeber0 MoritzWeber0 changed the base branch from main to refactor/consistent-apostroph December 18, 2025 21:00
@MoritzWeber0
Copy link
Copy Markdown
Member Author

MoritzWeber0 commented Dec 18, 2025

Thank your for your migration efforts ❤️

What do you think about having informations about the reservations as an own section seperated from the text at the end? Like you have it done at SNCF? This way users can clearly see information about the reservation. I wouldn't do this a 100% strict rule but I think we should try to stick to it.

What do you think? :) image

I tried to to group the reservation information below the reservation headings. In addition, I added a new section called "Scheduled routes" for the overview of lines.

@lenderom lenderom marked this pull request as ready for review December 18, 2025 21:25
@MoritzWeber0 MoritzWeber0 marked this pull request as draft December 18, 2025 21:31
Base automatically changed from refactor/consistent-apostroph to main December 19, 2025 08:02
@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review December 19, 2025 08:05
Comment thread content/country/austria/index.fr.md Outdated
Comment thread content/country/france/index.fr.md Outdated
Comment thread content/country/france/index.fr.md Outdated
Comment thread content/country/italy/index.fr.md Outdated
Comment thread content/country/italy/index.fr.md Outdated
Comment thread content/country/spain/index.fr.md Outdated
Comment thread content/country/united-kingdom/index.fr.md Outdated
Comment thread content/operator/dsb/index.fr.md
Comment thread AGENTS.md
@therobrob therobrob mentioned this pull request Dec 19, 2025
lenderom
lenderom previously approved these changes Dec 21, 2025
@lenderom
Copy link
Copy Markdown
Member

@MoritzWeber0
LGTM

@MoritzWeber0 MoritzWeber0 merged commit 62c241b into main Dec 21, 2025
7 checks passed
@MoritzWeber0 MoritzWeber0 deleted the feat/migrate-sp branch December 21, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants